From: Bin Liu <b-liu@ti.com>
To: Alexey Spirkov <AlexeiS@astrosoft.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"andrew@ncrmnt.org" <andrew@ncrmnt.org>
Subject: [v2] usb: musb: gadget: Fix big-endian arch issue
Date: Mon, 27 Aug 2018 10:19:50 -0500 [thread overview]
Message-ID: <20180827151950.GB21638@uda0271908> (raw)
Hi,
On Fri, Aug 03, 2018 at 09:03:36AM +0000, Alexey Spirkov wrote:
> Existing code is not applicable to big-endian machines
> ctrlrequest fields received in USB endian - i.e. in little-endian
> and should be converted to cpu endianness before usage.
>
> Signed-off-by: Alexey Spirkov <alexeis@astrosoft.ru>
> ---
> drivers/usb/musb/musb_gadget_ep0.c | 29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_gadget_ep0.c b/drivers/usb/musb/musb_gadget_ep0.c
> index 91a5027..90abacb 100644
> --- a/drivers/usb/musb/musb_gadget_ep0.c
> +++ b/drivers/usb/musb/musb_gadget_ep0.c
> @@ -82,7 +82,7 @@ static int service_tx_status_request(
> u16 tmp;
^^^^^^^^^^^^^
The patch cannot be applied. All the tabs are converted to whitespaces.
Regards,
-Bin.
next reply other threads:[~2018-08-27 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 15:19 Bin Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-03 9:41 [v2] usb: musb: gadget: Fix big-endian arch issue Alexey Spirkov
2018-08-03 9:16 Andy Shevchenko
2018-08-03 9:03 Alexey Spirkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827151950.GB21638@uda0271908 \
--to=b-liu@ti.com \
--cc=AlexeiS@astrosoft.ru \
--cc=andrew@ncrmnt.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox