linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Chen <peter.chen@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match
Date: Mon, 3 Sep 2018 16:10:02 +0200	[thread overview]
Message-ID: <20180903141002.GA12321@gmail.com> (raw)

Hi,

On Mon, Sep 03, 2018 at 02:36:11PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 03, 2018 at 04:14:41AM +0000, Peter Chen wrote:
> >  
> > > 
> > > The SPDX-License-Identifier is set to GPL-2.0+, which correspond to
> > > MODULE_LICENSE "GPL".
> > > 
> > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > ---
> > >  drivers/usb/chipidea/ci_hdrc_imx.c | 2 +-  drivers/usb/chipidea/usbmisc_imx.c | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > index 19f5f5f2a48a..555d398fbfa7 100644
> > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > > @@ -492,7 +492,7 @@ static struct platform_driver ci_hdrc_imx_driver =
> > > {  module_platform_driver(ci_hdrc_imx_driver);
> > > 
> > >  MODULE_ALIAS("platform:imx-usb");
> > > -MODULE_LICENSE("GPL v2");
> > > +MODULE_LICENSE("GPL");
> > >  MODULE_DESCRIPTION("CI HDRC i.MX USB binding");
> > > MODULE_AUTHOR("Marek Vasut <marex@denx.de>");
> > > MODULE_AUTHOR("Richard Zhao <richard.zhao@freescale.com>"); diff --git
> > > a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> > > index 34ad5bf8acd8..d9cfa00b8a6c 100644
> > > --- a/drivers/usb/chipidea/usbmisc_imx.c
> > > +++ b/drivers/usb/chipidea/usbmisc_imx.c
> > > @@ -633,6 +633,6 @@ static struct platform_driver usbmisc_imx_driver =
> > > {  module_platform_driver(usbmisc_imx_driver);
> > > 
> > >  MODULE_ALIAS("platform:usbmisc-imx");
> > > -MODULE_LICENSE("GPL v2");
> > > +MODULE_LICENSE("GPL");
> > >  MODULE_DESCRIPTION("driver for imx usb non-core registers");
> > > MODULE_AUTHOR("Richard Zhao <richard.zhao@freescale.com>");
> > 
> > Greg, does this is a useful change? I am not sure.
> 
> As the two licenses are not matching, something needs to be fixed here,
> don't you agree?

I just want to fill in that the former license text (removed in
51b751f112dcbb24b46051fe64c2ddbe8aa367ea) was:

- * The code contained herein is licensed under the GNU General Public
- * License. You may obtain a copy of the GNU General Public License
- * Version 2 or later at the following locations:

According to this, the SPDX-identifier is valid and the MODULE_LICENSE
should be fixed.

> 
> Please read include/linux/modules.h for what the strings mean, that
> should help explain things more.
> 
> greg k-h

Best regards
Marcus Folkesson

             reply	other threads:[~2018-09-03 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 14:10 Marcus Folkesson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-03 12:36 usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match Greg Kroah-Hartman
2018-09-03  4:14 Peter Chen
2018-09-02 17:36 Marcus Folkesson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903141002.GA12321@gmail.com \
    --to=marcus.folkesson@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).