* [v4,2/3] dt-bindings: usb: renesas_usbhs: add clock-names property
@ 2018-09-10 9:52 Yoshihiro Shimoda
0 siblings, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2018-09-10 9:52 UTC (permalink / raw)
To: balbi, robh+dt, mark.rutland
Cc: gregkh, linux-usb, linux-renesas-soc, devicetree,
Yoshihiro Shimoda
R-Car Gen3 needs to enable clocks of both host and peripheral.
Otherwise, other side device cannot work correctly. So, this patch
adds a property of clock-names for R-Car Gen3 as an optional.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 087140a..dbdb92c 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -26,7 +26,9 @@ Required properties:
- reg: Base address and length of the register for the USBHS
- interrupts: Interrupt specifier for the USBHS
- - clocks: A list of phandle + clock specifier pairs
+ - clocks: A list of phandle + clock specifier pairs. In case of
+ "renesas,rcar-gen3-usbhs" compatible device, first clock should be
+ peripheral and second one should be host.
Optional properties:
- renesas,buswait: Integer to use BUSWAIT register
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v4,2/3] dt-bindings: usb: renesas_usbhs: add clock-names property
@ 2018-09-10 18:26 Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-09-10 18:26 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: balbi, mark.rutland, gregkh, linux-usb, linux-renesas-soc,
devicetree
On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote:
> R-Car Gen3 needs to enable clocks of both host and peripheral.
> Otherwise, other side device cannot work correctly. So, this patch
> adds a property of clock-names for R-Car Gen3 as an optional.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 087140a..dbdb92c 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -26,7 +26,9 @@ Required properties:
>
> - reg: Base address and length of the register for the USBHS
> - interrupts: Interrupt specifier for the USBHS
> - - clocks: A list of phandle + clock specifier pairs
> + - clocks: A list of phandle + clock specifier pairs. In case of
> + "renesas,rcar-gen3-usbhs" compatible device, first clock should be
> + peripheral and second one should be host.
This should have said how many clocks. That's still not clear except for
"renesas,rcar-gen3-usbhs".
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v4,2/3] dt-bindings: usb: renesas_usbhs: add clock-names property
@ 2018-09-11 2:38 Yoshihiro Shimoda
0 siblings, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2018-09-11 2:38 UTC (permalink / raw)
To: Rob Herring
Cc: balbi@kernel.org, mark.rutland@arm.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Hi Rob,
> From: Rob Herring, Sent: Tuesday, September 11, 2018 3:27 AM
>
> On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote:
> > R-Car Gen3 needs to enable clocks of both host and peripheral.
> > Otherwise, other side device cannot work correctly. So, this patch
> > adds a property of clock-names for R-Car Gen3 as an optional.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > index 087140a..dbdb92c 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > @@ -26,7 +26,9 @@ Required properties:
> >
> > - reg: Base address and length of the register for the USBHS
> > - interrupts: Interrupt specifier for the USBHS
> > - - clocks: A list of phandle + clock specifier pairs
> > + - clocks: A list of phandle + clock specifier pairs. In case of
> > + "renesas,rcar-gen3-usbhs" compatible device, first clock should be
> > + peripheral and second one should be host.
>
> This should have said how many clocks. That's still not clear except for
> "renesas,rcar-gen3-usbhs".
Thank you for your comments! I'll revise it.
Best regards,
Yoshihiro Shimoda
> Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-11 2:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-10 18:26 [v4,2/3] dt-bindings: usb: renesas_usbhs: add clock-names property Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 2:38 Yoshihiro Shimoda
2018-09-10 9:52 Yoshihiro Shimoda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).