linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	Roger Quadros <rogerq@ti.com>, Lee Jones <lee.jones@linaro.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [1/3] mfd: omap-usb-host: Use regular platform device probe mechanism
Date: Tue, 11 Sep 2018 08:48:38 -0700	[thread overview]
Message-ID: <20180911154838.GZ5662@atomide.com> (raw)

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [180911 15:10]:
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -855,31 +856,14 @@ static struct platform_driver usbhs_omap_driver = {
>  		.pm		= &usbhsomap_dev_pm_ops,
>  		.of_match_table = usbhs_omap_dt_ids,
>  	},
> +	.probe		= usbhs_omap_probe,
>  	.remove		= usbhs_omap_remove,
>  };

So I have this already along few other fixes in patch
"[PATCH] mfd: omap-usb-host: Fix dts probe of children".

> +module_platform_driver(usbhs_omap_driver);
> +
>  MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
>  MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
>  MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
> -
> -static int __init omap_usbhs_drvinit(void)
> -{
> -	return platform_driver_probe(&usbhs_omap_driver, usbhs_omap_probe);
> -}
> -
> -/*
> - * init before ehci and ohci drivers;
> - * The usbhs core driver should be initialized much before
> - * the omap ehci and ohci probe functions are called.
> - * This usbhs core driver should be initialized after
> - * usb tll driver
> - */
> -fs_initcall_sync(omap_usbhs_drvinit);
> -
> -static void __exit omap_usbhs_drvexit(void)
> -{
> -	platform_driver_unregister(&usbhs_omap_driver);
> -}
> -module_exit(omap_usbhs_drvexit);

Seems like part can then become part of your clean-up
for v4.20 then?

Regards,

Tony

             reply	other threads:[~2018-09-11 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 15:48 Tony Lindgren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-11 16:12 [1/3] mfd: omap-usb-host: Use regular platform device probe mechanism Laurent Pinchart
2018-09-11 15:53 Ladislav Michl
2018-09-11 15:06 Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911154838.GZ5662@atomide.com \
    --to=tony@atomide.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).