[1/3] usb: xhci: tegra: Firmware header is little endian

[1/3] usb: xhci: tegra: Firmware header is little endian

[Mathias Nyman]

From: Thierry Reding <treding@nvidia.com>

The XUSB firmware header is in little endian byte order, so make the
fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
sparse when the fields are used with the endian-aware __le32_to_cpu()
and __le16_to_cpu() accessors, respectively.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
 drivers/usb/host/xhci-tegra.c | 52 +++++++++++++++++++++----------------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index 4b463e5..4ee510a 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -107,35 +107,35 @@
 #define IMEM_BLOCK_SIZE				256
 
 struct tegra_xusb_fw_header {
-	u32 boot_loadaddr_in_imem;
-	u32 boot_codedfi_offset;
-	u32 boot_codetag;
-	u32 boot_codesize;
-	u32 phys_memaddr;
-	u16 reqphys_memsize;
-	u16 alloc_phys_memsize;
-	u32 rodata_img_offset;
-	u32 rodata_section_start;
-	u32 rodata_section_end;
-	u32 main_fnaddr;
-	u32 fwimg_cksum;
-	u32 fwimg_created_time;
-	u32 imem_resident_start;
-	u32 imem_resident_end;
-	u32 idirect_start;
-	u32 idirect_end;
-	u32 l2_imem_start;
-	u32 l2_imem_end;
-	u32 version_id;
+	__le32 boot_loadaddr_in_imem;
+	__le32 boot_codedfi_offset;
+	__le32 boot_codetag;
+	__le32 boot_codesize;
+	__le32 phys_memaddr;
+	__le16 reqphys_memsize;
+	__le16 alloc_phys_memsize;
+	__le32 rodata_img_offset;
+	__le32 rodata_section_start;
+	__le32 rodata_section_end;
+	__le32 main_fnaddr;
+	__le32 fwimg_cksum;
+	__le32 fwimg_created_time;
+	__le32 imem_resident_start;
+	__le32 imem_resident_end;
+	__le32 idirect_start;
+	__le32 idirect_end;
+	__le32 l2_imem_start;
+	__le32 l2_imem_end;
+	__le32 version_id;
 	u8 init_ddirect;
 	u8 reserved[3];
-	u32 phys_addr_log_buffer;
-	u32 total_log_entries;
-	u32 dequeue_ptr;
-	u32 dummy_var[2];
-	u32 fwimg_len;
+	__le32 phys_addr_log_buffer;
+	__le32 total_log_entries;
+	__le32 dequeue_ptr;
+	__le32 dummy_var[2];
+	__le32 fwimg_len;
 	u8 magic[8];
-	u32 ss_low_power_entry_timeout;
+	__le32 ss_low_power_entry_timeout;
 	u8 num_hsic_port;
 	u8 padding[139]; /* Pad to 256 bytes */
 };

[1/3] usb: xhci: tegra: Firmware header is little endian

[Greg Kroah-Hartman]

On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The XUSB firmware header is in little endian byte order, so make the
> fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
> sparse when the fields are used with the endian-aware __le32_to_cpu()
> and __le16_to_cpu() accessors, respectively.

This isn't a "bug" in that no code is changed, so why is it needed for
4.19-final?

Shouldn't this be fine to merge in 4.20-rc1?

thanks,

greg k-h

[1/3] usb: xhci: tegra: Firmware header is little endian

[Thierry Reding]

On Fri, Sep 14, 2018 at 03:01:22PM +0200, Greg KH wrote:
> On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The XUSB firmware header is in little endian byte order, so make the
> > fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
> > sparse when the fields are used with the endian-aware __le32_to_cpu()
> > and __le16_to_cpu() accessors, respectively.
> 
> This isn't a "bug" in that no code is changed, so why is it needed for
> 4.19-final?
> 
> Shouldn't this be fine to merge in 4.20-rc1?

Yeah, I don't think there's a need to rush this. It's only to fix a
warning from sparse, but it shouldn't impact any code since the code
itself already properly parses the firmware in little endian byte
order.

Thierry

[1/3] usb: xhci: tegra: Firmware header is little endian

[Greg Kroah-Hartman]

On Mon, Sep 17, 2018 at 08:40:44AM +0200, Thierry Reding wrote:
> On Fri, Sep 14, 2018 at 03:01:22PM +0200, Greg KH wrote:
> > On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote:
> > > From: Thierry Reding <treding@nvidia.com>
> > > 
> > > The XUSB firmware header is in little endian byte order, so make the
> > > fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
> > > sparse when the fields are used with the endian-aware __le32_to_cpu()
> > > and __le16_to_cpu() accessors, respectively.
> > 
> > This isn't a "bug" in that no code is changed, so why is it needed for
> > 4.19-final?
> > 
> > Shouldn't this be fine to merge in 4.20-rc1?
> 
> Yeah, I don't think there's a need to rush this. It's only to fix a
> warning from sparse, but it shouldn't impact any code since the code
> itself already properly parses the firmware in little endian byte
> order.

Thanks for confirming.  Mathias, I'll wait for you to resend this as
part of a 4.20-rc1 submission.

thanks,

greg k-h