Linux USB
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Cc: "kbuild@01.org" <kbuild@01.org>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	John Youn <John.Youn@synopsys.com>
Subject: usb: dwc2: Disable all EP's on disconnect
Date: Thu, 20 Sep 2018 13:30:07 +0300	[thread overview]
Message-ID: <20180920103007.ivs36zfo3rl46b7k@mwanda> (raw)

On Thu, Sep 20, 2018 at 10:21:26AM +0000, Minas Harutyunyan wrote:
> Hi Dan,
> 
> On 9/20/2018 1:49 PM, Dan Carpenter wrote:
> > is is obviously deliberate that we drop the other thread's lock and
> > then take it ourselves.  But I don't think that can be right at all.
> > How do we know that it's safe for the other thread to drop the lock?
> > 
> > There should at least be a long comment in front of the code explaining
> > why it's safe to steal the lock like this.
> 
> Please review patch version 2: "[PATCH v2] usb: dwc2: Disable all EP's 
> on disconnect"

These are automated emails from the kbuild bot.  I just review them and
forward them.  I'm not on the list.

I'm going to trust that you fixed it in an appropriate way.  :)

regards,
dan carpenter

             reply	other threads:[~2018-09-20 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 10:30 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-20 10:21 usb: dwc2: Disable all EP's on disconnect Minas Harutyunyan
2018-09-20  9:48 Dan Carpenter
2018-09-19  5:05 kbuild test robot
2018-09-18 14:18 Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920103007.ivs36zfo3rl46b7k@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=John.Youn@synopsys.com \
    --cc=Minas.Harutyunyan@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=kbuild@01.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox