From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thierry Reding <treding@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>, linux-usb@vger.kernel.org
Subject: [1/3] usb: xhci: tegra: Firmware header is little endian
Date: Thu, 20 Sep 2018 12:36:04 +0200 [thread overview]
Message-ID: <20180920103604.GB14252@kroah.com> (raw)
On Mon, Sep 17, 2018 at 08:40:44AM +0200, Thierry Reding wrote:
> On Fri, Sep 14, 2018 at 03:01:22PM +0200, Greg KH wrote:
> > On Fri, Sep 14, 2018 at 03:33:29PM +0300, Mathias Nyman wrote:
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > The XUSB firmware header is in little endian byte order, so make the
> > > fields __le32 and __le16 instead of u32 and u16 to avoid warnings from
> > > sparse when the fields are used with the endian-aware __le32_to_cpu()
> > > and __le16_to_cpu() accessors, respectively.
> >
> > This isn't a "bug" in that no code is changed, so why is it needed for
> > 4.19-final?
> >
> > Shouldn't this be fine to merge in 4.20-rc1?
>
> Yeah, I don't think there's a need to rush this. It's only to fix a
> warning from sparse, but it shouldn't impact any code since the code
> itself already properly parses the firmware in little endian byte
> order.
Thanks for confirming. Mathias, I'll wait for you to resend this as
part of a 4.20-rc1 submission.
thanks,
greg k-h
next reply other threads:[~2018-09-20 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 10:36 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-17 6:40 [1/3] usb: xhci: tegra: Firmware header is little endian Thierry Reding
2018-09-14 13:01 Greg Kroah-Hartman
2018-09-14 12:33 Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920103604.GB14252@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).