[01/10] usb: xhci-mtk: resume USB3 roothub first

[01/10] usb: xhci-mtk: resume USB3 roothub first

[Mathias Nyman]

From: Chunfeng Yun <chunfeng.yun@mediatek.com>

Give USB3 devices a better chance to enumerate at USB3 speeds if
they are connected to a suspended host.
Porting from "671ffdff5b13 xhci: resume USB 3 roothub first"

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
 drivers/usb/host/xhci-mtk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 7334da9..71d0d33 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -642,10 +642,10 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
 	xhci_mtk_host_enable(mtk);
 
 	xhci_dbg(xhci, "%s: restart port polling\n", __func__);
-	set_bit(HCD_FLAG_POLL_RH, &hcd->flags);
-	usb_hcd_poll_rh_status(hcd);
 	set_bit(HCD_FLAG_POLL_RH, &xhci->shared_hcd->flags);
 	usb_hcd_poll_rh_status(xhci->shared_hcd);
+	set_bit(HCD_FLAG_POLL_RH, &hcd->flags);
+	usb_hcd_poll_rh_status(hcd);
 	return 0;
 }
 

[01/10] usb: xhci-mtk: resume USB3 roothub first

[Greg Kroah-Hartman]

On Thu, Sep 13, 2018 at 03:23:54PM +0300, Mathias Nyman wrote:
> From: Chunfeng Yun <chunfeng.yun@mediatek.com>
> 
> Give USB3 devices a better chance to enumerate at USB3 speeds if
> they are connected to a suspended host.
> Porting from "671ffdff5b13 xhci: resume USB 3 roothub first"
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
>  drivers/usb/host/xhci-mtk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Isn't this a bugfix for 4.19-final?  And maybe for stable?

thanks,

greg k-h

[01/10] usb: xhci-mtk: resume USB3 roothub first

[Mathias Nyman]

On 14.09.2018 16:27, Greg KH wrote:
> On Thu, Sep 13, 2018 at 03:23:54PM +0300, Mathias Nyman wrote:
>> From: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Give USB3 devices a better chance to enumerate at USB3 speeds if
>> they are connected to a suspended host.
>> Porting from "671ffdff5b13 xhci: resume USB 3 roothub first"
>>
>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> ---
>>   drivers/usb/host/xhci-mtk.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Isn't this a bugfix for 4.19-final?  And maybe for stable?
> 

This was part of a 6 patch series that mostly contained mediatek
bandwidth scheduling improvements.

But I agree, this first one could go to 4.19 with stable flag.

-Mathias

[01/10] usb: xhci-mtk: resume USB3 roothub first

[Greg Kroah-Hartman]

On Mon, Sep 17, 2018 at 10:35:46AM +0300, Mathias Nyman wrote:
> On 14.09.2018 16:27, Greg KH wrote:
> > On Thu, Sep 13, 2018 at 03:23:54PM +0300, Mathias Nyman wrote:
> > > From: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > 
> > > Give USB3 devices a better chance to enumerate at USB3 speeds if
> > > they are connected to a suspended host.
> > > Porting from "671ffdff5b13 xhci: resume USB 3 roothub first"
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > ---
> > >   drivers/usb/host/xhci-mtk.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Isn't this a bugfix for 4.19-final?  And maybe for stable?
> > 
> 
> This was part of a 6 patch series that mostly contained mediatek
> bandwidth scheduling improvements.
> 
> But I agree, this first one could go to 4.19 with stable flag.

Ok, can you redo this whole series, and the 4.19-final series, so we get
these all straightened out as to which patch goes where, and resend?

I've dropped all of your pending patches from my queue now.

thanks,

greg k-h