linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Ajay Gupta <ajayg@nvidia.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Peter Rosin <peda@axentia.se>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: [v12,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU
Date: Tue, 2 Oct 2018 09:27:08 +0200	[thread overview]
Message-ID: <20181002072708.GA999@kunai> (raw)

Hi,

> > > We got confirmation from HW team about 4 byte read limitation. There
> > > has to be a STOP after every single read cycle. One read cycle
> > > supports maximum of
> > > 4 byte burst. I will update the patches with a comment on this.
> > 
> > Could it be that this is more an SMBus controller than an I2C controller?
> > I haven't looked at the specs but maybe populating smbus_xfer instead of
> > master_xfer is an option here?
> I think its more of i2c controller and we do mention " .max_read_len = 4" in
> " struct i2c_adapter_quirks". Do you still see something missing here?

Well, if there has to be STOP after a read, then you can't do a transfer
containing "write-read-write", or? So, I wondered if this controller is
of the type which can mainly do "write-then-read" transfers only (check
I2C_AQ_COMB* quirk flags). And for some of those controller types, it
might be even easier to drop generic I2C transfers and only handle the
SMBUS calls.

I didn't check this driver closely yet, so I can't tell if/what it needs
from the above. I wanted to give this input already, though.

Regards,

   Wolfram

             reply	other threads:[~2018-10-02  7:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  7:27 Wolfram Sang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-24 19:44 [v12,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU Greg Kroah-Hartman
2018-10-24 17:46 Ajay Gupta
2018-10-16 23:21 Wolfram Sang
2018-10-16 17:46 Peter Rosin
2018-10-02 16:34 Ajay Gupta
2018-10-01 22:04 Ajay Gupta
2018-10-01 21:16 Ajay Gupta
2018-10-01 19:51 Peter Rosin
2018-10-01 19:37 Wolfram Sang
2018-10-01 19:33 Ajay Gupta
2018-09-13 23:32 Ajay Gupta
2018-09-13 11:11 Heikki Krogerus
2018-09-13  7:36 Peter Rosin
2018-09-12 22:22 Ajay Gupta
2018-09-12 21:57 Peter Rosin
2018-09-12 18:02 Ajay Gupta
2018-09-12 11:02 Peter Rosin
2018-09-12 10:25 Peter Rosin
2018-09-11 22:48 Ajay Gupta
2018-09-11 20:57 Peter Rosin
2018-09-11 17:45 Ajay Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002072708.GA999@kunai \
    --to=wsa@the-dreams.de \
    --cc=ajayg@nvidia.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).