From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobias Herzog <t-herzog@gmx.de>
Cc: oneukum@suse.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [2/2] cdc-acm: correct counting of UART states in serial state notification
Date: Tue, 2 Oct 2018 10:34:14 -0700 [thread overview]
Message-ID: <20181002173414.GA7850@kroah.com> (raw)
On Sat, Sep 22, 2018 at 10:11:11PM +0200, Tobias Herzog wrote:
> The usb standard ("Universal Serial Bus Class Definitions for Communication
> Devices") distiguishes between "consistent signals" (DSR, DCD), and
> "irregular signals" (break, ring, parity error, framing error, overrun).
> The bits of "irregular signals" are set, if this error/event occurred on
> the device side and are immeadeatly unset, if the serial state notification
> was sent.
> Like other drivers of real serial ports do, just the occurence of those
> events should be counted in serial_icounter_struct (but no 1->0
> transitions).
>
> Signed-off-by: Tobias Herzog <t-herzog@gmx.de>
> ---
> drivers/usb/class/cdc-acm.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Oliver, any thoughts about this patch series?
thanks,
greg k-h
next reply other threads:[~2018-10-02 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 17:34 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-04 13:34 [2/2] cdc-acm: correct counting of UART states in serial state notification Oliver Neukum
2018-09-22 20:11 Tobias Herzog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002173414.GA7850@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=t-herzog@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).