From: David Miller <davem@davemloft.net>
To: Igor.Russkikh@aquantia.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Dmitry.Bezrukov@aquantia.com
Subject: [net-next,03/19] net: usb: aqc111: Add implementation of read and write commands
Date: Fri, 05 Oct 2018 10:40:55 -0700 (PDT) [thread overview]
Message-ID: <20181005.104055.1450398286878441400.davem@davemloft.net> (raw)
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
Date: Fri, 5 Oct 2018 10:24:44 +0000
> +static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value,
> + u16 index, u16 size, void *data, int nopm)
> +{
> + int ret;
> + int (*fn)(struct usbnet *dev, u8 cmd, u8 reqtype, u16 value,
> + u16 index, void *data, u16 size);
Again, please order local variables from longest to shortest line.
I won't explicitly point out the others, you need to audit your entire
submission for this problem and fix it up.
Thank you.
next reply other threads:[~2018-10-05 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 17:40 David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-09 13:33 [net-next,03/19] net: usb: aqc111: Add implementation of read and write commands Bjørn Mork
2018-10-08 13:44 Oliver Neukum
2018-10-05 10:24 Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005.104055.1450398286878441400.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).