* [4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-16 5:01 Peter Chen
0 siblings, 0 replies; 3+ messages in thread
From: Peter Chen @ 2018-10-16 5:01 UTC (permalink / raw)
To: linux-usb@vger.kernel.org, frieder.schrempf@exceet.de
Cc: dl-linux-imx, robh+dt@kernel.org, devicetree@vger.kernel.org,
Peter Chen
For USB HSIC, the data and strobe pin needs to be pulled down
at default, we consider it as "idle" state. When the USB host
is ready to be used, the strobe pin needs to be pulled up,
we consider it as "active" state.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index 529e51879fb2..10c8d793ea49 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -81,6 +81,7 @@ Optional properties:
mux state of 1 indicates host mode.
- mux-control-names: Shall be "usb_switch" if mux-controls is specified.
- pinctrl-names: Names for optional pin modes in "default", "host", "device"
+ Or names for HSIC "idle" and "active" pin modes.
- pinctrl-n: alternate pin modes
i.mx specific properties
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-16 16:24 Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2018-10-16 16:24 UTC (permalink / raw)
To: Peter Chen
Cc: USB list, Schrempf Frieder, NXP Linux Team, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Peter,
On Tue, Oct 16, 2018 at 2:02 AM Peter Chen <peter.chen@nxp.com> wrote:
>
> For USB HSIC, the data and strobe pin needs to be pulled down
> at default, we consider it as "idle" state. When the USB host
> is ready to be used, the strobe pin needs to be pulled up,
> we consider it as "active" state.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 529e51879fb2..10c8d793ea49 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -81,6 +81,7 @@ Optional properties:
> mux state of 1 indicates host mode.
> - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
> - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> + Or names for HSIC "idle" and "active" pin modes.
I don't think this description is clear enough.
Could you please add a real dts snippet for the HSIC case instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-17 1:04 Peter Chen
0 siblings, 0 replies; 3+ messages in thread
From: Peter Chen @ 2018-10-17 1:04 UTC (permalink / raw)
To: Fabio Estevam
Cc: USB list, Schrempf Frieder, dl-linux-imx, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> On Tue, Oct 16, 2018 at 2:02 AM Peter Chen <peter.chen@nxp.com> wrote:
> >
> > For USB HSIC, the data and strobe pin needs to be pulled down at
> > default, we consider it as "idle" state. When the USB host is ready to
> > be used, the strobe pin needs to be pulled up, we consider it as
> > "active" state.
> >
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > index 529e51879fb2..10c8d793ea49 100644
> > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> > @@ -81,6 +81,7 @@ Optional properties:
> > mux state of 1 indicates host mode.
> > - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
> > - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> > + Or names for HSIC "idle" and "active" pin modes.
>
> I don't think this description is clear enough.
>
> Could you please add a real dts snippet for the HSIC case instead?
Ok, I will add example like below at next version.
usb@02184000 { /* USB OTG */ {
...
pinctrl-names = "idle", "active";
pinctrl-0 = <&pinctrl_usbh2_1>;
pinctrl-1 = <&pinctrl_usbh2_2>;
...
};
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-17 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-16 5:01 [4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2018-10-16 16:24 Fabio Estevam
2018-10-17 1:04 Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).