* [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-22 5:43 Peter Chen
0 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2018-10-22 5:43 UTC (permalink / raw)
To: linux-usb@vger.kernel.org
Cc: dl-linux-imx, robh+dt@kernel.org, devicetree@vger.kernel.org,
frieder.schrempf@exceet.de, festevam@gmail.com, Peter Chen
For USB HSIC, the data and strobe pin needs to be pulled down
at default, we consider it as "idle" state. When the USB host
is ready to be used, the strobe pin needs to be pulled up,
we consider it as "active" state.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index 529e51879fb2..10c8d793ea49 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -81,6 +81,7 @@ Optional properties:
mux state of 1 indicates host mode.
- mux-control-names: Shall be "usb_switch" if mux-controls is specified.
- pinctrl-names: Names for optional pin modes in "default", "host", "device"
+ Or names for HSIC "idle" and "active" pin modes.
- pinctrl-n: alternate pin modes
i.mx specific properties
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-22 14:54 Frieder Schrempf
0 siblings, 0 replies; 4+ messages in thread
From: Frieder Schrempf @ 2018-10-22 14:54 UTC (permalink / raw)
To: Peter Chen, linux-usb@vger.kernel.org
Cc: dl-linux-imx, robh+dt@kernel.org, devicetree@vger.kernel.org,
frieder.schrempf@exceet.de, festevam@gmail.com
On 22.10.18 07:43, Peter Chen wrote:
> For USB HSIC, the data and strobe pin needs to be pulled down
> at default, we consider it as "idle" state. When the USB host
> is ready to be used, the strobe pin needs to be pulled up,
> we consider it as "active" state.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 529e51879fb2..10c8d793ea49 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -81,6 +81,7 @@ Optional properties:
> mux state of 1 indicates host mode.
> - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
> - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> + Or names for HSIC "idle" and "active" pin modes.
I think you forgot to improve this description. Maybe something like this:
pinctrl-names: Names for optional pin modes for "default", "host" or
"device". In case of HSIC-mode "idle" and "active" pin
modes are mandatory. In this case the "idle" state needs
to pull down the data and strobe pin and the "active"
state needs to pull up the strobe pin.
Thanks,
Frieder
> - pinctrl-n: alternate pin modes
>
> i.mx specific properties
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-22 14:59 Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-10-22 14:59 UTC (permalink / raw)
To: frieder.schrempf
Cc: Peter Chen, USB list, NXP Linux Team, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Schrempf Frieder
On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
> I think you forgot to improve this description. Maybe something like this:
>
> pinctrl-names: Names for optional pin modes for "default", "host" or
> "device". In case of HSIC-mode "idle" and "active" pin
> modes are mandatory. In this case the "idle" state needs
> to pull down the data and strobe pin and the "active"
> state needs to pull up the strobe pin.
Correct, and the dts example is also missing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
@ 2018-10-23 5:59 Peter Chen
0 siblings, 0 replies; 4+ messages in thread
From: Peter Chen @ 2018-10-23 5:59 UTC (permalink / raw)
To: Fabio Estevam, frieder.schrempf@kontron.de
Cc: USB list, dl-linux-imx, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Schrempf Frieder
> On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>
> > I think you forgot to improve this description. Maybe something like this:
> >
> > pinctrl-names: Names for optional pin modes for "default", "host" or
> > "device". In case of HSIC-mode "idle" and "active" pin
> > modes are mandatory. In this case the "idle" state needs
> > to pull down the data and strobe pin and the "active"
> > state needs to pull up the strobe pin.
>
> Correct, and the dts example is also missing.
Thanks, both. Will do your comments.
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-23 5:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-22 5:43 [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2018-10-22 14:54 Frieder Schrempf
2018-10-22 14:59 Fabio Estevam
2018-10-23 5:59 Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).