* [08/10] usb: typec: Add support for usb role switch in rt1711h driver
@ 2018-10-27 9:58 Yu Chen
0 siblings, 0 replies; 3+ messages in thread
From: Yu Chen @ 2018-10-27 9:58 UTC (permalink / raw)
To: linux-usb, devicetree, linux-kernel
Cc: suzhuangluan, kongfei, Yu Chen, Heikki Krogerus,
Greg Kroah-Hartman, Lucas Tsai, shufan_lee, John Stultz,
Binghui Wang
This patch add struct device_connection to rt1711h driver to support
find "usb-role-switch" in tcpm_register_port.
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lucas Tsai <lucas_tsai@richtek.com>
Cc: shufan_lee <shufan_lee@richtek.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Binghui Wang <wangbinghui@hisilicon.com>
Signed-off-by: Yu Chen <chenyu56@huawei.com>
---
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
index 017389021b96..5f8b952612fe 100644
--- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
+++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
@@ -39,6 +39,7 @@ struct rt1711h_chip {
struct tcpci_data data;
struct tcpci *tcpci;
struct device *dev;
+ struct device_connection dev_conn;
};
static int rt1711h_read16(struct rt1711h_chip *chip, unsigned int reg, u16 *val)
@@ -237,6 +238,7 @@ static int rt1711h_probe(struct i2c_client *client,
{
int ret;
struct rt1711h_chip *chip;
+ const char *dev_conn_end;
ret = rt1711h_check_revision(client);
if (ret < 0) {
@@ -254,6 +256,7 @@ static int rt1711h_probe(struct i2c_client *client,
return PTR_ERR(chip->data.regmap);
chip->dev = &client->dev;
+ dev_set_name(chip->dev, "rt1711h");
i2c_set_clientdata(client, chip);
ret = rt1711h_sw_reset(chip);
@@ -264,6 +267,15 @@ static int rt1711h_probe(struct i2c_client *client,
if (ret < 0)
return ret;
+ ret = device_property_read_string(chip->dev, "dev-conn-end",
+ &dev_conn_end);
+ if (!ret) {
+ chip->dev_conn.endpoint[0] = "rt1711h";
+ chip->dev_conn.endpoint[1] = dev_conn_end;
+ chip->dev_conn.id = "usb-role-switch";
+ device_connection_add(&chip->dev_conn);
+ }
+
chip->data.init = rt1711h_init;
chip->data.set_vconn = rt1711h_set_vconn;
chip->data.start_drp_toggling = rt1711h_start_drp_toggling;
@@ -279,6 +291,9 @@ static int rt1711h_remove(struct i2c_client *client)
struct rt1711h_chip *chip = i2c_get_clientdata(client);
tcpci_unregister_port(chip->tcpci);
+ if (chip->dev_conn.id)
+ device_connection_remove(&chip->dev_conn);
+
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [08/10] usb: typec: Add support for usb role switch in rt1711h driver
@ 2018-10-29 11:58 Heikki Krogerus
0 siblings, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2018-10-29 11:58 UTC (permalink / raw)
To: Yu Chen
Cc: linux-usb, devicetree, linux-kernel, suzhuangluan, kongfei,
Greg Kroah-Hartman, Lucas Tsai, shufan_lee, John Stultz,
Binghui Wang
On Sat, Oct 27, 2018 at 05:58:18PM +0800, Yu Chen wrote:
> This patch add struct device_connection to rt1711h driver to support
> find "usb-role-switch" in tcpm_register_port.
>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Lucas Tsai <lucas_tsai@richtek.com>
> Cc: shufan_lee <shufan_lee@richtek.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Binghui Wang <wangbinghui@hisilicon.com>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index 017389021b96..5f8b952612fe 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -39,6 +39,7 @@ struct rt1711h_chip {
> struct tcpci_data data;
> struct tcpci *tcpci;
> struct device *dev;
> + struct device_connection dev_conn;
> };
>
> static int rt1711h_read16(struct rt1711h_chip *chip, unsigned int reg, u16 *val)
> @@ -237,6 +238,7 @@ static int rt1711h_probe(struct i2c_client *client,
> {
> int ret;
> struct rt1711h_chip *chip;
> + const char *dev_conn_end;
>
> ret = rt1711h_check_revision(client);
> if (ret < 0) {
> @@ -254,6 +256,7 @@ static int rt1711h_probe(struct i2c_client *client,
> return PTR_ERR(chip->data.regmap);
>
> chip->dev = &client->dev;
> + dev_set_name(chip->dev, "rt1711h");
> i2c_set_clientdata(client, chip);
>
> ret = rt1711h_sw_reset(chip);
> @@ -264,6 +267,15 @@ static int rt1711h_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
>
> + ret = device_property_read_string(chip->dev, "dev-conn-end",
> + &dev_conn_end);
> + if (!ret) {
> + chip->dev_conn.endpoint[0] = "rt1711h";
> + chip->dev_conn.endpoint[1] = dev_conn_end;
> + chip->dev_conn.id = "usb-role-switch";
> + device_connection_add(&chip->dev_conn);
> + }
That is wrong. You should not read name of a device from a property.
Regardless of that, I don't think this patch is needed at all. You
need to describe this kind connection with OF device graph
(Documentation/devicetree/bindings/graph.txt).
I've prepared a proposal how we should be able handle graphs in the
device connection API:
https://lkml.org/lkml/2018/10/24/613
thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [08/10] usb: typec: Add support for usb role switch in rt1711h driver
@ 2018-10-29 12:22 Yu Chen
0 siblings, 0 replies; 3+ messages in thread
From: Yu Chen @ 2018-10-29 12:22 UTC (permalink / raw)
To: Heikki Krogerus
Cc: wangbinghui, linux-usb, devicetree, linux-kernel, suzhuangluan,
kongfei, Greg Kroah-Hartman, Lucas Tsai, shufan_lee, John Stultz
On 2018/10/29 19:58, Heikki Krogerus wrote:
> On Sat, Oct 27, 2018 at 05:58:18PM +0800, Yu Chen wrote:
>> This patch add struct device_connection to rt1711h driver to support
>> find "usb-role-switch" in tcpm_register_port.
>>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Lucas Tsai <lucas_tsai@richtek.com>
>> Cc: shufan_lee <shufan_lee@richtek.com>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Cc: Binghui Wang <wangbinghui@hisilicon.com>
>> Signed-off-by: Yu Chen <chenyu56@huawei.com>
>> ---
>> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
>> index 017389021b96..5f8b952612fe 100644
>> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
>> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
>> @@ -39,6 +39,7 @@ struct rt1711h_chip {
>> struct tcpci_data data;
>> struct tcpci *tcpci;
>> struct device *dev;
>> + struct device_connection dev_conn;
>> };
>>
>> static int rt1711h_read16(struct rt1711h_chip *chip, unsigned int reg, u16 *val)
>> @@ -237,6 +238,7 @@ static int rt1711h_probe(struct i2c_client *client,
>> {
>> int ret;
>> struct rt1711h_chip *chip;
>> + const char *dev_conn_end;
>>
>> ret = rt1711h_check_revision(client);
>> if (ret < 0) {
>> @@ -254,6 +256,7 @@ static int rt1711h_probe(struct i2c_client *client,
>> return PTR_ERR(chip->data.regmap);
>>
>> chip->dev = &client->dev;
>> + dev_set_name(chip->dev, "rt1711h");
>> i2c_set_clientdata(client, chip);
>>
>> ret = rt1711h_sw_reset(chip);
>> @@ -264,6 +267,15 @@ static int rt1711h_probe(struct i2c_client *client,
>> if (ret < 0)
>> return ret;
>>
>> + ret = device_property_read_string(chip->dev, "dev-conn-end",
>> + &dev_conn_end);
>> + if (!ret) {
>> + chip->dev_conn.endpoint[0] = "rt1711h";
>> + chip->dev_conn.endpoint[1] = dev_conn_end;
>> + chip->dev_conn.id = "usb-role-switch";
>> + device_connection_add(&chip->dev_conn);
>> + }
> That is wrong. You should not read name of a device from a property.
>
> Regardless of that, I don't think this patch is needed at all. You
> need to describe this kind connection with OF device graph
> (Documentation/devicetree/bindings/graph.txt).
>
> I've prepared a proposal how we should be able handle graphs in the
> device connection API:
> https://lkml.org/lkml/2018/10/24/613
I will fix this patch. Thanks!
>
> thanks,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-29 12:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-29 11:58 [08/10] usb: typec: Add support for usb role switch in rt1711h driver Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2018-10-29 12:22 Yu Chen
2018-10-27 9:58 Yu Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).