linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v3,1/3] dt-bindings: connector: Add self-powered property
@ 2018-10-01 19:44 Badhri Jagan Sridharan
  0 siblings, 0 replies; 3+ messages in thread
From: Badhri Jagan Sridharan @ 2018-10-01 19:44 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Heikki Krogerus, Greg Kroah-Hartman,
	Chanwoo Choi, Andrzej Hajda, Li Jun, linux, jackp
  Cc: devicetree, linux-kernel, linux-usb, Badhri Jagan Sridharan

From USB_PD_R3_0
7.1.5 Response to Hard Resets
Device operation during and after a Hard Reset is defined as follows:
Self-powered devices Should Not disconnect from USB during a Hard Reset
(see Section 9.1.2).
Bus powered devices will disconnect from USB during a Hard Reset due to the
loss of their power source.

Therefore it is necessary to know whether the port belongs to
a device which is self powered or bus powered. This change
adds "self-powered" flag to the connector class which present indicates
that the port belongs to a device that is self powered. Else it is
bus powered usb device.

Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
-------
Changes is v3:
- Rebase on top of usb-next
- no change w.r.t to this patch. Same as previous versions.

No v2 version as the patch was introduced there.
---
 Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
index d90e17e2428b..a9a2f2fc44f2 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
@@ -14,6 +14,8 @@ Optional properties:
 - label: symbolic name for the connector,
 - type: size of the connector, should be specified in case of USB-A, USB-B
   non-fullsize connectors: "mini", "micro".
+- self-powered: Set this property if the usb device that has its own power
+  source.
 
 Optional properties for usb-c-connector:
 - power-role: should be one of "source", "sink" or "dual"(DRP) if typec

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [v3,1/3] dt-bindings: connector: Add self-powered property
@ 2018-11-02 13:27 Heikki Krogerus
  0 siblings, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2018-11-02 13:27 UTC (permalink / raw)
  To: Badhri Jagan Sridharan, Rob Herring
  Cc: Mark Rutland, Greg Kroah-Hartman, Chanwoo Choi, Andrzej Hajda,
	Li Jun, linux, jackp, devicetree, linux-kernel, linux-usb

On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote:
> >From USB_PD_R3_0
> 7.1.5 Response to Hard Resets
> Device operation during and after a Hard Reset is defined as follows:
> Self-powered devices Should Not disconnect from USB during a Hard Reset
> (see Section 9.1.2).
> Bus powered devices will disconnect from USB during a Hard Reset due to the
> loss of their power source.
> 
> Therefore it is necessary to know whether the port belongs to
> a device which is self powered or bus powered. This change
> adds "self-powered" flag to the connector class which present indicates
> that the port belongs to a device that is self powered. Else it is
> bus powered usb device.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>

Rob, I can see you acked one of the patches modifying tcpm.c in this
series, but did you mean to put the tag to this patch instead?

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> -------
> Changes is v3:
> - Rebase on top of usb-next
> - no change w.r.t to this patch. Same as previous versions.
> 
> No v2 version as the patch was introduced there.
> 
> ---
>  Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index d90e17e2428b..a9a2f2fc44f2 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -14,6 +14,8 @@ Optional properties:
>  - label: symbolic name for the connector,
>  - type: size of the connector, should be specified in case of USB-A, USB-B
>    non-fullsize connectors: "mini", "micro".
> +- self-powered: Set this property if the usb device that has its own power
> +  source.
>  
>  Optional properties for usb-c-connector:
>  - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> -- 
> 2.19.0.605.g01d371f741-goog

thanks,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [v3,1/3] dt-bindings: connector: Add self-powered property
@ 2018-11-02 13:44 Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-11-02 13:44 UTC (permalink / raw)
  To: heikki.krogerus
  Cc: badhri, Rob Herring, Mark Rutland, Greg Kroah-Hartman, cw00.choi,
	a.hajda, jun.li, Guenter Roeck, jackp, devicetree,
	Linux Kernel Mailing List, linux-usb

On Fri, Nov 2, 2018 at 8:28 AM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote:
> > >From USB_PD_R3_0
> > 7.1.5 Response to Hard Resets
> > Device operation during and after a Hard Reset is defined as follows:
> > Self-powered devices Should Not disconnect from USB during a Hard Reset
> > (see Section 9.1.2).
> > Bus powered devices will disconnect from USB during a Hard Reset due to the
> > loss of their power source.
> >
> > Therefore it is necessary to know whether the port belongs to
> > a device which is self powered or bus powered. This change
> > adds "self-powered" flag to the connector class which present indicates
> > that the port belongs to a device that is self powered. Else it is
> > bus powered usb device.
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
>
> Rob, I can see you acked one of the patches modifying tcpm.c in this
> series, but did you mean to put the tag to this patch instead?

Hum, indeed. Looks like a scripting fail in my reply. The R-by was for this one.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-02 13:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02 13:27 [v3,1/3] dt-bindings: connector: Add self-powered property Heikki Krogerus
  -- strict thread matches above, loose matches on Subject: below --
2018-11-02 13:44 Rob Herring
2018-10-01 19:44 Badhri Jagan Sridharan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).