linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Ajay Gupta <ajayg@nvidia.com>
Cc: heikki.krogerus@linux.intel.com, peda@axentia.se,
	andriy.shevchenko@linux.intel.com, linux-usb@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: [v15,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU
Date: Fri, 9 Nov 2018 17:49:40 +0100	[thread overview]
Message-ID: <20181109164939.GM1031@kunai> (raw)

> @@ -140,5 +140,6 @@ obj-$(CONFIG_I2C_SIBYTE)	+= i2c-sibyte.o
>  obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o
>  obj-$(CONFIG_SCx200_ACB)	+= scx200_acb.o
>  obj-$(CONFIG_I2C_FSI)		+= i2c-fsi.o
> +obj-$(CONFIG_I2C_NVIDIA_GPU)	+= i2c-nvidia-gpu.o

Oh, I fixed this up and moved it to the place where it is corresponding
to in Kconfig.

> +static u32 gpu_i2c_functionality(struct i2c_adapter *adap)
> +{
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +}

I can't send an incremental patch for this, I need to ask: did you try
SMBUS_QUICK with it? Given the restrictions of this controller, I have
my doubts. I might be wrong, though. 'i2cdetect' from i2c-tools lets you
easily check it.

             reply	other threads:[~2018-11-09 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 16:49 Wolfram Sang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-11-09 18:40 [v15,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU Wolfram Sang
2018-11-09 18:28 Ajay Gupta
2018-11-09 18:04 Ajay Gupta
2018-11-09 17:54 Wolfram Sang
2018-11-09 17:27 Ajay Gupta
2018-11-09 16:43 Wolfram Sang
2018-10-26 16:36 Ajay Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109164939.GM1031@kunai \
    --to=wsa@the-dreams.de \
    --cc=ajayg@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).