From: Johan Hovold <johan@kernel.org>
To: Nikolaj Fogh <nikolajfogh@gmail.com>
Cc: nfogh@vectory.com, linux-usb@vger.kernel.org
Subject: Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors.
Date: Mon, 12 Nov 2018 10:54:24 +0100 [thread overview]
Message-ID: <20181112095424.GE13311@localhost> (raw)
On Wed, Oct 31, 2018 at 09:16:48PM +0100, Nikolaj Fogh wrote:
> I have experienced that the ftdi_sio driver gives less-than-optimal baud rates as the driver truncates instead of rounds to nearest during baud rate divisor calculation.
Please break your lines at 72 cols or so, and use the common subject
prefix (e.g. "USB: serial: ftdi_sio: improve...") with a concise
summary.
> This patch improves on the baud rate generation. The generated baud rate corresponds to the optimal baud rate achievable with the chip. This is what the windows driver gives as well.
How did you verify this? Did you trace and compare the divisors
actually requested by the Windows driver, or did you measure the
resulting rates using a scope?
Thanks,
Johan
next reply other threads:[~2018-11-12 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 9:54 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 9:33 Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors Johan Hovold
2018-11-15 14:16 Nikolaj Fogh
2018-11-15 12:46 Johan Hovold
2018-11-15 8:24 Johan Hovold
2018-11-13 19:19 Nikolaj Fogh
2018-10-31 20:16 Nikolaj Fogh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112095424.GE13311@localhost \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nfogh@vectory.com \
--cc=nikolajfogh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).