linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices
@ 2018-12-08  1:47 Kyle Williams
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Williams @ 2018-12-08  1:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: kdgwill, Greg Kroah-Hartman, Alan Stern, Mathias Nyman,
	Nicolas Boichat, Jon Flatley, Felipe Balbi, Kai-Heng Feng,
	Kuppuswamy Sathyanarayanan, Harry Pan, Emmanuel Pescosta,
	Danilo Krummrich, Dmitry Fleytman Dmitry Fleytman, linux-usb

From: Kyle Williams <kdgwill@chromium.org>

Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of certain Logitech uvc devices and other powered media
devices such causes 'not enough bandwidth for new device state' error.

This patch enables the USB_QUIRK_NO_LPM quirk entries for all connected
Logitech UVC devices indicating LPM should remain disabled for the device.

Signed-off-by: Kyle Williams <kdgwill@chromium.org>
---
 drivers/usb/core/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0690fcff0ea2..bbbb7e6df958 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -440,7 +440,7 @@ static const struct usb_device_id usb_quirk_list[] = {
 static const struct usb_device_id usb_interface_quirk_list[] = {
 	/* Logitech UVC Cameras */
 	{ USB_VENDOR_AND_INTERFACE_INFO(0x046d, USB_CLASS_VIDEO, 1, 0),
-	  .driver_info = USB_QUIRK_RESET_RESUME },
+	  .driver_info = USB_QUIRK_RESET_RESUME | USB_QUIRK_NO_LPM },
 
 	{ }  /* terminating entry must be last */
 };

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices
@ 2018-12-12 11:37 Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-12-12 11:37 UTC (permalink / raw)
  To: Kyle Williams
  Cc: linux-kernel, Alan Stern, Mathias Nyman, Nicolas Boichat,
	Jon Flatley, Felipe Balbi, Kai-Heng Feng,
	Kuppuswamy Sathyanarayanan, Harry Pan, Emmanuel Pescosta,
	Danilo Krummrich, Dmitry Fleytman Dmitry Fleytman, linux-usb

On Fri, Dec 07, 2018 at 08:47:22PM -0500, Kyle Williams wrote:
> From: Kyle Williams <kdgwill@chromium.org>
> 
> Description: Some USB device / host controller combinations seem to have
> problems with Link Power management. In particular it is described that
> the combination of certain Logitech uvc devices and other powered media
> devices such causes 'not enough bandwidth for new device state' error.

Same thing with "Description:" :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-12 11:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08  1:47 [v3,2/2] USB: quirks: Disable LPM for Logitech UVC devices Kyle Williams
  -- strict thread matches above, loose matches on Subject: below --
2018-12-12 11:37 Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).