From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Revert "usb: dwc3: pci: Use devm functions to get the phy GPIOs" From: Stephan Gerhold Message-Id: <20181209164639.GA7988@gerhold.net> Date: Sun, 9 Dec 2018 17:46:39 +0100 To: Hans de Goede Cc: Andy Shevchenko , Felipe Balbi , Greg Kroah-Hartman , USB List-ID: T24gU3VuLCBEZWMgMDksIDIwMTggYXQgMDQ6Mjg6MDdQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSwKPiAKPiBPbiAwOS0xMi0xOCAxNjowNywgU3RlcGhhbiBHZXJob2xkIHdyb3Rl Ogo+ID4gT24gU3VuLCBEZWMgMDksIDIwMTggYXQgMDQ6NDQ6MTZQTSArMDIwMCwgQW5keSBTaGV2 Y2hlbmtvIHdyb3RlOgo+ID4gPiBPbiBUaHUsIERlYyA2LCAyMDE4IGF0IDg6NDkgUE0gU3RlcGhh biBHZXJob2xkIDxzdGVwaGFuQGdlcmhvbGQubmV0PiB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiBD b21taXQgMjExZjY1OGI3YjQwICgidXNiOiBkd2MzOiBwY2k6IFVzZSBkZXZtIGZ1bmN0aW9ucyB0 byBnZXQKPiA+ID4gPiB0aGUgcGh5IEdQSU9zIikgY2hhbmdlZCB0aGUgY29kZSB0byBjbGFpbSB0 aGUgUEhZIEdQSU9zIHBlcm1hbmVudGx5Cj4gPiA+ID4gZm9yIEludGVsIEJheXRyYWlsIGRldmlj ZXMuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBjYXVzZXMgaXNzdWVzIHdoZW4gdGhlIGFjdHVhbCBQ SFkgZHJpdmVyIGF0dGVtcHRzIHRvIGNsYWltIHRoZQo+ID4gPiA+IHNhbWUgR1BJTyBkZXNjcmlw dG9ycy4gRm9yIGV4YW1wbGUsIHR1c2IxMjEwIG5vdyBmYWlscyB0byBwcm9iZSB3aXRoOgo+ID4g PiA+IAo+ID4gPiA+ICAgIHR1c2IxMjEwOiBwcm9iZSBvZiBkd2MzLjAuYXV0by51bHBpIGZhaWxl ZCB3aXRoIGVycm9yIC0xNiAoRUJVU1kpCj4gPiA+ID4gCj4gPiA+ID4gZHdjMy1wY2kgbmVlZHMg dG8gdHVybiBvbiB0aGUgUEhZIG9uY2UgYmVmb3JlIGR3YzMgaXMgbG9hZGVkLCBidXQKPiA+ID4g PiB1c3VhbGx5IHRoZSBQSFkgZHJpdmVyIHdpbGwgdGhlbiBob2xkIHRoZSBHUElPcyB0byB0dXJu IG9mZiB0aGUKPiA+ID4gPiBQSFkgd2hlbiByZXF1ZXN0ZWQgKGUuZy4gZHVyaW5nIHN1c3BlbmQp Lgo+ID4gPiA+IAo+ID4gPiA+IFRvIGZpeCB0aGUgcHJvYmxlbSwgdGhpcyByZXZlcnRzIHRoZSBj b21taXQgdG8gcmVzdG9yZSB0aGUgb2xkCj4gPiA+ID4gYmVoYXZpb3IgdG8gcHV0IHRoZSBHUElP cyBpbW1lZGlhdGVseSBhZnRlciB1c2FnZS4KPiA+ID4gPiAKPiA+ID4gPiBMaW5rOiBodHRwczov L3d3dy5zcGluaWNzLm5ldC9saXN0cy9saW51eC11c2IvbXNnMTc0NjgxLmh0bWwKPiA+ID4gPiBD Yzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFN0ZXBoYW4g R2VyaG9sZCA8c3RlcGhhbkBnZXJob2xkLm5ldD4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgIGRyaXZl cnMvdXNiL2R3YzMvZHdjMy1wY2kuYyB8IDggKysrKy0tLS0KPiA+ID4gPiAgIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1wY2kuYyBiL2RyaXZlcnMvdXNiL2R3YzMv ZHdjMy1wY2kuYwo+ID4gPiA+IGluZGV4IDg0Mjc5NTg1NmJmNC4uZmRjNmU0ZTQwM2U4IDEwMDY0 NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1wY2kuYwo+ID4gPiA+ICsrKyBi L2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1wY2kuYwo+ID4gPiA+IEBAIC0xNzAsMjAgKzE3MCwyMCBA QCBzdGF0aWMgaW50IGR3YzNfcGNpX3F1aXJrcyhzdHJ1Y3QgZHdjM19wY2kgKmR3YykKPiA+ID4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICogcHV0IHRoZSBncGlvIGRlc2NyaXB0b3JzIGFn YWluIGhlcmUgYmVjYXVzZSB0aGUgcGh5IGRyaXZlcgo+ID4gPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgKiBtaWdodCB3YW50IHRvIGdyYWIgdGhlbSwgdG9vLgo+ID4gPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgKi8KPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICBncGlv ID0gZGV2bV9ncGlvZF9nZXRfb3B0aW9uYWwoJnBkZXYtPmRldiwgImNzIiwKPiA+ID4gPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1BJT0Rf T1VUX0xPVyk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZ3BpbyA9IGdwaW9kX2dl dF9vcHRpb25hbCgmcGRldi0+ZGV2LCAiY3MiLCBHUElPRF9PVVRfTE9XKTsKPiA+ID4gPiAgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKElTX0VSUihncGlvKSkKPiA+ID4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUihncGlvKTsKPiA+ID4gPiAKPiA+ ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKGdw aW8sIDEpOwo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGdwaW9kX3B1dChncGlvKTsK PiA+ID4gPiAKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICBncGlvID0gZGV2bV9ncGlv ZF9nZXRfb3B0aW9uYWwoJnBkZXYtPmRldiwgInJlc2V0IiwKPiA+ID4gPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1BJT0RfT1VUX0xPVyk7 Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZ3BpbyA9IGdwaW9kX2dldF9vcHRpb25h bCgmcGRldi0+ZGV2LCAicmVzZXQiLCBHUElPRF9PVVRfTE9XKTsKPiA+ID4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKElTX0VSUihncGlvKSkKPiA+ID4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUihncGlvKTsKPiA+ID4gPiAKPiA+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGdwaW8pIHsKPiA+ID4gPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXAoZ3BpbywgMSk7Cj4g PiA+IAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3Bpb2RfcHV0KGdw aW8pOwo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVzbGVlcF9yYW5n ZSgxMDAwMCwgMTEwMDApOwo+ID4gPiAKPiA+ID4gSWYgc29tZXRoaW5nIGhhcHBlbnMgdG8gR1BJ TyBsaW5lIGluIGJldHdlZW4gb2YgdGhlc2UgbGluZXMsIHRoZSBzbGVlcAo+ID4gPiBtaWdodCBi ZWNvbWUgb2Jzb2xldGUuIFNob3VsZG4ndCBncGlvZF9wdXQoKSBiZSBwbGFjZWQgYWZ0ZXI/Cj4g PiAKPiA+IFRoYXQncyBhIGdvb2QgcG9pbnQsIGJ1dCBJIGJlbGlldmUgdGhpcyB3b3VsZCBiZSBt b3JlIGFwcHJvcHJpYXRlbHkKPiA+IGZpeGVkIGluIGEgc2VwYXJhdGUgcGF0Y2gsIHNpbmNlIHRo aXMgaXMganVzdCBhbiBleGFjdCByZXZlcnQgb2YKPiA+IDIxMWY2NThiN2I0MCAoInVzYjogZHdj MzogcGNpOiBVc2UgZGV2bSBmdW5jdGlvbnMgdG8gZ2V0IHRoZSBwaHkgR1BJT3MiKQo+ID4gKFRo aXMgaXMgdGhlIHdheSBpdCB3YXMgd3JpdHRlbiB3aGVuIGl0IHdhcyBhZGRlZCB0byBtYWlubGlu ZSA0IHllYXJzCj4gPiBhZ28uLi4pCj4gPiAKPiA+IEkgY2FuIHNlbmQgYSBzZXBhcmF0ZSBwYXRj aCBmb3IgdGhpcywgb3Igd291bGQgeW91IGxpa2UgdG8/Cj4gCj4gUHJvcGVybHkgZml4aW5nIHRo aXMgd291bGQgcmVxdWlyZSByZWxlYXNpbmcgKmJvdGgqIEdQSU9zICphZnRlciogdGhlCj4gVUxQ SSB2ZW5kb3IgYW5kIHByb2R1Y3QgSURzIGhhdmUgYmVlbiByZWFkLiBXaGljaCB3aWxsIHJlcXVp cmUgYWRkaW5nCj4gc29tZSBnZW5lcmljIGNhbGxiYWNrIGp1c3QgZm9yIHRoaXMgdG8gdGhlIGdl bmVyaWMgbm9uIHBsYXRmb3JtL3BjaQo+IHNwZWNpZmljIGR3YzMgY29kZS4gV2hpY2ggSU1ITyBp cyBub3Qgd29ydGggdGhlIHRyb3VibGUgc2luY2UgaW4KPiBwcmFjdGljZSB0aGlzIGlzIG5vdCBy ZWFsbHkgYSBwcm9ibGVtLgoKSG1tLCB5ZWFoLCBJIHdhcyB0aGlua2luZyBhYm91dCBhIHNwZWNp ZmljIHNpdHVhdGlvbiB3aGVyZSBpdCB3b3VsZCBoYXZlIAptYWRlIGEgZGlmZmVyZW5jZSBpZiBi b3RoIEdQSU9zIHdlcmUgcHV0IGFmdGVyIHRoZSBkZWxheSAobm90IGFmdGVyIHRoZQpVTFBJIHZl bmRvci9wcm9kdWN0IElEcyBoYXZlIGJlZW4gcmVhZCkuIEJ1dCBub3cgdGhhdCBJIHRoaW5rIGFi b3V0IGl0CmFnYWluLCBpdCBkb2VzIG5vdCBtYWtlIG11Y2ggc2Vuc2UuLi4gTmV2ZXIgbWluZC4g KE1heWJlIEFuZHkgaGFzIAphbm90aGVyIGNvbW1lbnQgaGVyZS4uKQoKPiAKPiBSZWdhcmRzLAo+ IAo+IEhhbnMKPgo=