From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mathias Payer <mathias.payer@nebelwelt.net>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
bigeasy@linutronix.de, benquike@gmail.com
Subject: USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data
Date: Mon, 10 Dec 2018 08:18:34 +0100 [thread overview]
Message-ID: <20181210071834.GC7511@kroah.com> (raw)
On Sun, Dec 09, 2018 at 09:17:58PM +0100, Mathias Payer wrote:
> > The whole kernel is full of situations where an int is returned and if it's
> > negative it's an error. Why is this location so different?
> >
> > Just check < 0 and be done with it.
>
> OK, whatever you prefer.
My fault, I was tired and suggested the other way...
> I've attached the updated patch. (Greg, please add your Signed-off-by).
Patches can't be attached, I'll fix this up and resend, thanks.
greg k-h
next reply other threads:[~2018-12-10 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:18 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-09 20:40 USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data David Miller
2018-12-09 20:17 Mathias Payer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210071834.GC7511@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benquike@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.payer@nebelwelt.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).