From: Johan Hovold <johan@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [-next] USB: serial: mos7840: remove set but not used variables 'number, serial'
Date: Mon, 10 Dec 2018 10:24:17 +0100 [thread overview]
Message-ID: <20181210092417.GD31358@localhost> (raw)
On Fri, Dec 07, 2018 at 02:50:42AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate':
> drivers/usb/serial/mos7840.c:1584:16: warning:
> variable 'number' set but not used [-Wunused-but-set-variable]
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_change_port_settings':
> drivers/usb/serial/mos7840.c:1695:21: warning:
> variable 'serial' set but not used [-Wunused-but-set-variable]
>
> 'number' never used since introduction in commit 3f5429746d91 ("USB: Moschip
> 7840 USB-Serial Driver")
>
> 'serial' not used since commit 5833041f1b13 ("USB: serial: remove unnecessary
> reinitialisations of urb->dev")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied for -next, thanks.
Johan
next reply other threads:[~2018-12-10 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 9:24 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-07 2:50 [-next] USB: serial: mos7840: remove set but not used variables 'number, serial' YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210092417.GD31358@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).