From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kyle Williams <kdgwill@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Jon Flatley <jflat@chromium.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-usb@vger.kernel.org
Subject: [v3,1/2] USB: quirks: Check device interface LPM capability
Date: Wed, 12 Dec 2018 12:37:09 +0100 [thread overview]
Message-ID: <20181212113709.GA20058@kroah.com> (raw)
On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote:
> From: Kyle Williams <kdgwill@chromium.org>
>
> Description: enable the ability to disable LPM for all devices matched
> by interface information
Why have "Description:" in here? Of course this is the description :)
And the subject doesn't make much sense, what does this have to do with
quirks?
Also, you need more information here in the description about why you
are doing all of this, as it is, I have no idea why this patch is needed
at all.
thanks,
greg k-h
next reply other threads:[~2018-12-12 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:37 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-11 9:09 [v3,1/2] USB: quirks: Check device interface LPM capability Greg Kroah-Hartman
2019-01-10 15:49 Kyle Williams
2018-12-08 1:47 Kyle Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212113709.GA20058@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=drinkcat@chromium.org \
--cc=felipe.balbi@linux.intel.com \
--cc=jflat@chromium.org \
--cc=kdgwill@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).