From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Jörgen Storvist" <jorgen.storvist@gmail.com>, linux-usb@vger.kernel.org
Subject: USB: serial: option: add Fibocom NL678 series
Date: Fri, 21 Dec 2018 17:08:38 +0100 [thread overview]
Message-ID: <20181221160838.GA5963@kroah.com> (raw)
On Fri, Dec 21, 2018 at 03:11:43PM +0100, Johan Hovold wrote:
> On Fri, Dec 21, 2018 at 02:56:16PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Dec 21, 2018 at 02:40:44PM +0100, Jörgen Storvist wrote:
> > > Added USB serial option driver support for Fibocom NL678 series cellular
> > > module: VID 2cb7 and PIDs 0x0104 and 0x0105.
> > > Reserved network and ADB interfaces.
> > >
> > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> > > P: Vendor=2cb7 ProdID=0104 Rev=03.10
> > > S: Manufacturer=Fibocom
> > > S: Product=Fibocom NL678-E Modem
> > > S: SerialNumber=12345678
> > > C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> > > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> > > I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> > > I: If#= 5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > >
> > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0
> > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> > > P: Vendor=2cb7 ProdID=0105 Rev=03.10
> > > S: Manufacturer=Fibocom
> > > S: Product=Fibocom NL678-E Modem
> > > S: SerialNumber=12345678
> > > C: #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA
> > > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> > > I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > > I: If#= 4 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether
> > > I: If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> > > I: If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > >
> > > Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> >
> > Johan, if you ack this, I can take this in my tree now...
>
> Looks good to me, although checkpatch reports two spaces before tabs,
> which perhaps you can remove when applying? Should be fine either way.
Yes, I fixed that up, thanks.
greg k-h
next reply other threads:[~2018-12-21 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 16:08 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-21 14:11 USB: serial: option: add Fibocom NL678 series Johan Hovold
2018-12-21 13:56 Greg Kroah-Hartman
2018-12-21 13:40 Jörgen Storvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221160838.GA5963@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jorgen.storvist@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).