From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v1] leds: fix regression in usbport led trigger From: Christian Lamparter Message-Id: <20181225204956.17897-1-chunkeey@gmail.com> Date: Tue, 25 Dec 2018 21:49:56 +0100 To: linux-usb@vger.kernel.org, linux-leds@vger.kernel.org Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Jacek Anaszewski , Greg Kroah-Hartman List-ID: VGhlIHBhdGNoICJ1c2I6IHNpbXBsaWZ5IHVzYnBvcnQgdHJpZ2dlciIgdG9nZXRoZXIgd2l0aAoi bGVkczogdHJpZ2dlcnM6IGFkZCBkZXZpY2UgYXR0cmlidXRlIHN1cHBvcnQiIGNhdXNlZCBhbgpy ZWdyZXNzaW9uIGZvciB0aGUgdXNicG9ydCB0cmlnZ2VyLiBpdCB3aWxsIG5vIGxvbmdlcgplbnVt ZXJhdGUgYW55IGFjdGl2ZSB1c2IgaHViIHBvcnRzIHVuZGVyIHRoZSAicG9ydHMiCmRpcmVjdG9y eSBpbiB0aGUgc3lzZnMgY2xhc3MgZGlyZWN0b3J5LCBpZiB0aGUgdXNiIGhvc3QKZHJpdmVycyBh cmUgZnVsbHkgaW5pdGlhbGl6ZWQgYmVmb3JlIHRoZSB1c2Jwb3J0IHRyaWdnZXIKd2FzIGxvYWRl ZC4KClRoZSByZWFzb24gaXMgdGhhdCB0aGUgdXNicG9ydCBkcml2ZXIgdHJpZXMgdG8gcmVnaXN0 ZXIKdGhlIHN5c2ZzIGVudHJpZXMgZHVyaW5nIHRoZSBhY3RpdmF0ZSgpIGNhbGxiYWNrLiBBbmQg dGhpcwp3aWxsIGZhaWwgd2l0aCAtMiAvIEVOT0VOVCBiZWNhdXNlIHRoZSBwYXRjaAoibGVkczog dHJpZ2dlcnM6IGFkZCBkZXZpY2UgYXR0cmlidXRlIHN1cHBvcnQiIG1hZGUgaXQgc28KdGhhdCB0 aGUgc3lzZnMgInBvcnRzIiBncm91cCB3YXMgb25seSBiZWluZyBhZGRlZCBhZnRlcgp0aGUgYWN0 aXZhdGUoKSBjYWxsYmFjayBzdWNjZWVkZWQuCgpUaGlzIHZlcnNpb24gb2YgdGhlIHBhdGNoIG1v dmVzIHRoZSBkZXZpY2VfYWRkX2dyb3VwcygpCmluIGZyb250IG9mIHRoZSBjYWxsIHRvIHRoZSB0 cmlnZ2VyJ3MgYWN0aXZhdGUoKSBmdW5jdGlvbgppbiBvcmRlciB0byBzb2x2ZSB0aGUgcHJvYmxl bS4KCkNjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgpD YzogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KQ2M6 IFJhZmHFgiBNacWCZWNraSA8emFqZWM1QGdtYWlsLmNvbT4KRml4ZXM6IDZmN2IwYmFkODgzOSAo InVzYjogc2ltcGxpZnkgdXNicG9ydCB0cmlnZ2VyIikKU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFu IExhbXBhcnRlciA8Y2h1bmtlZXlAZ21haWwuY29tPgotLS0KClRoaXMgdmVyc2lvbiBvZiB0aGUg cGF0Y2ggLi4uIG9mIHdoaWNoIHdpbGwgYmUgbWFueSBtb3JlPyEKCnllYWgsIGRldmljZV9hZGRf Z3JvdXBzKCkgaW4gZnJvbnQgb2YgYWN0aXZhdGUoKSB3b3Jrcwpmb3IgdGhlIHVzYnBvcnQgZHJp dmVyIHNpbmNlIGl0IGR5bmFtaWNhbGx5IHJlZ2lzdGVycwp0aGUgZW50cmllcyBpbiAicG9ydHMi LiBIb3dldmVyLCBpZiBhIHRyaWdnZXIgaGFzIGEKc3RhdGljIGxpc3Qgb2YgZW50aXRpZXMgdGhp cyBjYW4gZ2V0IG1vcmUgY29tcGxpY2F0ZWQsCnNpbmNlIEkgdGhpbmsgdGhlIHN5c2ZzIGVudHJp ZXMgd2lsbCBub3cgYmUgYXZhaWxhYmxlCmJlZm9yZSB0aGUgYWN0aXZhdGUoKSBjYWxsIGV2ZW4g c3RhcnRlZCBhbmQgdGhpcyBjYW4KZW5kIHVwIGJhZGx5LiBTbywgaXMgdGhlcmUgYW55IGJldHRl ciBhcHByb2FjaD8KSW50cm9kdWNlIGEgInBvc3RfYWN0aXZhdGUoKSIgY2FsbGJhY2s/IE9yIHVz ZSB0aGUgZXZlbnQKc3lzdGVtIGFuZCBtYWtlIHVzYnBvcnQgdHJpZ2dlciBvbiB0aGUgS09CSl9D SEFOR0U/IHVzZQphIChkZWxheWVkKSB3b3JrX3N0cnVjdCBpbiB1c2Jwb3J0IHRvIHJlZ2lzdGVy IHRoZSBwb3J0cwphdCBhIHNsaWdodGx5IGxhdGVyIHRpbWU/IGV0Yy4uLgoKKE5vdGU6IEknbSBo aXR0aW5nIHRoaXMgb24gNC4xOSB0b28sIHNvIHdoYXRldmVyIHRoZQpyZWFsIGZpeCB3aWxsIGxv b2sgbGlrZSBpdCBzaG91bGQgYmUgYmFja3BvcnRlZCkKLS0tCiBkcml2ZXJzL2xlZHMvbGVkLXRy aWdnZXJzLmMgfCAxOSArKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvbGVk LXRyaWdnZXJzLmMgYi9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMKaW5kZXggMTdkNzNkYjE0 NTZlLi4wOGU3YzcyNGE5ZGMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbGVkcy9sZWQtdHJpZ2dlcnMu YworKysgYi9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMKQEAgLTEzNCw2ICsxMzQsMTIgQEAg aW50IGxlZF90cmlnZ2VyX3NldChzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2Rldiwgc3RydWN0 IGxlZF90cmlnZ2VyICp0cmlnKQogCQlsZWRfc2V0X2JyaWdodG5lc3MobGVkX2NkZXYsIExFRF9P RkYpOwogCX0KIAlpZiAodHJpZykgeworCQlyZXQgPSBkZXZpY2VfYWRkX2dyb3VwcyhsZWRfY2Rl di0+ZGV2LCB0cmlnLT5ncm91cHMpOworCQlpZiAocmV0KSB7CisJCQlkZXZfZXJyKGxlZF9jZGV2 LT5kZXYsICJGYWlsZWQgdG8gYWRkIHRyaWdnZXIgYXR0cmlidXRlc1xuIik7CisJCQlnb3RvIGVy cl9hZGRfZ3JvdXBzOworCQl9CisKIAkJd3JpdGVfbG9ja19pcnFzYXZlKCZ0cmlnLT5sZWRkZXZf bGlzdF9sb2NrLCBmbGFncyk7CiAJCWxpc3RfYWRkX3RhaWwoJmxlZF9jZGV2LT50cmlnX2xpc3Qs ICZ0cmlnLT5sZWRfY2RldnMpOwogCQl3cml0ZV91bmxvY2tfaXJxcmVzdG9yZSgmdHJpZy0+bGVk ZGV2X2xpc3RfbG9jaywgZmxhZ3MpOwpAQCAtMTQ2LDEyICsxNTIsNiBAQCBpbnQgbGVkX3RyaWdn ZXJfc2V0KHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2LCBzdHJ1Y3QgbGVkX3RyaWdnZXIg KnRyaWcpCiAKIAkJaWYgKHJldCkKIAkJCWdvdG8gZXJyX2FjdGl2YXRlOwotCi0JCXJldCA9IGRl dmljZV9hZGRfZ3JvdXBzKGxlZF9jZGV2LT5kZXYsIHRyaWctPmdyb3Vwcyk7Ci0JCWlmIChyZXQp IHsKLQkJCWRldl9lcnIobGVkX2NkZXYtPmRldiwgIkZhaWxlZCB0byBhZGQgdHJpZ2dlciBhdHRy aWJ1dGVzXG4iKTsKLQkJCWdvdG8gZXJyX2FkZF9ncm91cHM7Ci0JCX0KIAl9CiAKIAlpZiAoZXZl bnQpIHsKQEAgLTE2NSwxNyArMTY1LDE4IEBAIGludCBsZWRfdHJpZ2dlcl9zZXQoc3RydWN0IGxl ZF9jbGFzc2RldiAqbGVkX2NkZXYsIHN0cnVjdCBsZWRfdHJpZ2dlciAqdHJpZykKIAogCXJldHVy biAwOwogCi1lcnJfYWRkX2dyb3VwczoKLQorZXJyX2FjdGl2YXRlOgorCWRldmljZV9yZW1vdmVf Z3JvdXBzKGxlZF9jZGV2LT5kZXYsIHRyaWctPmdyb3Vwcyk7CiAJaWYgKHRyaWctPmRlYWN0aXZh dGUpCiAJCXRyaWctPmRlYWN0aXZhdGUobGVkX2NkZXYpOwotZXJyX2FjdGl2YXRlOgogCiAJbGVk X2NkZXYtPnRyaWdnZXIgPSBOVUxMOwogCWxlZF9jZGV2LT50cmlnZ2VyX2RhdGEgPSBOVUxMOwog CXdyaXRlX2xvY2tfaXJxc2F2ZSgmbGVkX2NkZXYtPnRyaWdnZXItPmxlZGRldl9saXN0X2xvY2ss IGZsYWdzKTsKIAlsaXN0X2RlbCgmbGVkX2NkZXYtPnRyaWdfbGlzdCk7CiAJd3JpdGVfdW5sb2Nr X2lycXJlc3RvcmUoJmxlZF9jZGV2LT50cmlnZ2VyLT5sZWRkZXZfbGlzdF9sb2NrLCBmbGFncyk7 CisKK2Vycl9hZGRfZ3JvdXBzOgogCWxlZF9zZXRfYnJpZ2h0bmVzcyhsZWRfY2RldiwgTEVEX09G Rik7CiAKIAlyZXR1cm4gcmV0Owo=