linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Charles Yeh <charlesyeh522@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	gregkh@linuxfoundation.org, charles-yeh@prolific.com.tw,
	linux-usb@vger.kernel.org
Subject: Add Proliic new chip: PL2303TB & PL2303N(G)
Date: Tue, 8 Jan 2019 15:16:38 +0100	[thread overview]
Message-ID: <20190108141638.GG14782@localhost> (raw)

On Wed, Dec 19, 2018 at 06:26:06PM +0800, Charles Yeh wrote:
> Hi Johan & Greg,
>      Thansk for you check the patch file..
> 
> PL2303 is a general name on the market. In fact, PL2303 has the
> following various ICs.
> A type: PL2303H,
> B type: PL2303XA, PL2303HXA, PL2303HXB, PL2303HXC, PL2303HXD,
> PL2303EA, PL2303SA, PL2303RA, PL2303TA,  PL2303TB
> C type:PL2303HXN: PL2303GC, PL2303GS, PL2303GB, PL2303GT, PL2303GL,
> PL2303GE.  <<--used different PID, different VENDOR_REQUEST

Thanks for that summary. Much appreciated.

Does what the current driver calls TYPE_01 correspond to your "A type"
above?

> "Please split out in a separate patch and explain why it is needed.
> Alsoreplace the "magical" constants with descriptive defines."
>  I will push 3 patch file.
> 
> 1. Support PL2303TB(old chip, B type), only add new VID_PID
> 2. Support PL2303HXD(old chip, B type), /* only support External
> Pull-Up Mode on PL2303HXD chip*. /
> 3. Support PL2303HXN(new chip, C type), add new VID_PID, new
> VENDOR_WRITE_REQUEST/ VENDOR_READ_REQUEST, new H/W, S/W flow control
> setting.

Sounds good, but looks like your latest revision of the patch still does
all of the above in one patch...

Thanks,
Johan

             reply	other threads:[~2019-01-08 14:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 14:16 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-09  1:12 Add Proliic new chip: PL2303TB & PL2303N(G) Yeh.Charles [葉榮鑫]
2019-01-08 17:01 Johan Hovold
2018-12-26 12:28 Charles Yeh
2018-12-19 10:35 Greg Kroah-Hartman
2018-12-19 10:26 Charles Yeh
2018-12-18 10:02 Johan Hovold
2018-12-17 13:03 Greg Kroah-Hartman
2018-12-17  4:51 Charles Yeh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108141638.GG14782@localhost \
    --to=johan@kernel.org \
    --cc=charles-yeh@prolific.com.tw \
    --cc=charlesyeh522@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).