From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Pawel Laszczak <pawell@cadence.com>,
devicetree@vger.kernel.org, mark.rutland@arm.com,
linux-usb@vger.kernel.org, hdegoede@redhat.com,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com,
lkml <linux-kernel@vger.kernel.org>,
adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com,
nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com,
pjez@cadence.com, kurahul@cadence.com
Subject: [v2,5/5] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Thu, 10 Jan 2019 07:57:38 +0100 [thread overview]
Message-ID: <20190110065738.GA28817@kroah.com> (raw)
On Thu, Jan 10, 2019 at 09:30:41AM +0800, Peter Chen wrote:
> On Mon, Dec 24, 2018 at 12:44 AM Pawel Laszczak <pawell@cadence.com> wrote:
> - debugfs is nice to have feature, I suggest removing it at this
> initial version. Besides, role switch
> through /sys is normal feature, the end user may use it at real
> product, so, it is better at device's
> /sys entry instead of debugfs.
>
> - I don't know why you add "disable" at debugfs, please comment.
As you imply here, no real-world functionality should ever be in
debugfs as it is an optional system component and kernel code should
work just fine without it being enabled (as more and more systems are
disabling it due to the obvious security problems it has.)
thanks,
greg k-h
next reply other threads:[~2019-01-10 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 6:57 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-10 7:18 [v2,5/5] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-31 12:31 Pawel Laszczak
2018-12-31 9:42 Pawel Laszczak
2018-12-31 5:32 Pawel Laszczak
2018-12-29 7:41 Chunfeng Yun
2018-12-28 1:31 Peter Chen
2018-12-27 13:11 Pawel Laszczak
2018-12-27 9:36 Pawel Laszczak
2018-12-25 9:38 Peter Chen
2018-12-24 9:38 Peter Chen
2018-12-23 19:20 kbuild test robot
2018-12-23 17:19 Randy Dunlap
2018-12-23 15:13 Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110065738.GA28817@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adouglas@cadence.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hzpeterchen@gmail.com \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox