From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] leds: fix regression in usbport led trigger From: Christian Lamparter Message-Id: <20190111162945.31612-1-chunkeey@gmail.com> Date: Fri, 11 Jan 2019 17:29:45 +0100 To: linux-usb@vger.kernel.org, linux-leds@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Jacek Anaszewski , Greg Kroah-Hartman List-ID: VGhlIHBhdGNoICJ1c2I6IHNpbXBsaWZ5IHVzYnBvcnQgdHJpZ2dlciIgdG9nZXRoZXIgd2l0aAoi bGVkczogdHJpZ2dlcnM6IGFkZCBkZXZpY2UgYXR0cmlidXRlIHN1cHBvcnQiIGNhdXNlZCBhbgpy ZWdyZXNzaW9uIGZvciB0aGUgdXNicG9ydCB0cmlnZ2VyLiBpdCB3aWxsIG5vIGxvbmdlcgplbnVt ZXJhdGUgYW55IGFjdGl2ZSB1c2IgaHViIHBvcnRzIHVuZGVyIHRoZSAicG9ydHMiCmRpcmVjdG9y eSBpbiB0aGUgc3lzZnMgY2xhc3MgZGlyZWN0b3J5LCBpZiB0aGUgdXNiIGhvc3QKZHJpdmVycyBh cmUgZnVsbHkgaW5pdGlhbGl6ZWQgYmVmb3JlIHRoZSB1c2Jwb3J0IHRyaWdnZXIKd2FzIGxvYWRl ZC4KClRoZSByZWFzb24gaXMgdGhhdCB0aGUgdXNicG9ydCBkcml2ZXIgdHJpZXMgdG8gcmVnaXN0 ZXIKdGhlIHN5c2ZzIGVudHJpZXMgZHVyaW5nIHRoZSBhY3RpdmF0ZSgpIGNhbGxiYWNrLiBBbmQg dGhpcwp3aWxsIGZhaWwgd2l0aCAtMiAvIEVOT0VOVCBiZWNhdXNlIHRoZSBwYXRjaAoibGVkczog dHJpZ2dlcnM6IGFkZCBkZXZpY2UgYXR0cmlidXRlIHN1cHBvcnQiIG1hZGUgaXQgc28KdGhhdCB0 aGUgc3lzZnMgInBvcnRzIiBncm91cCB3YXMgb25seSBiZWluZyBhZGRlZCBhZnRlcgp0aGUgYWN0 aXZhdGUoKSBjYWxsYmFjayBzdWNjZWVkZWQuCgpUaGlzIHZlcnNpb24gb2YgdGhlIHBhdGNoIHJl dmVydHMgcGFydHMgb2YgdGhlCiJ1c2I6IHNpbXBsaWZ5IHVzYnBvcnQgdHJpZ2dlciIgcGF0Y2gg YW5kIHJlc3RvcmVzCnVzYnBvcnQgdHJpZ2dlcidzIGZ1bmN0aW9uYWxpdHkuCgpGaXhlczogNmY3 YjBiYWQ4ODM5ICgidXNiOiBzaW1wbGlmeSB1c2Jwb3J0IHRyaWdnZXIiKQpTaWduZWQtb2ZmLWJ5 OiBDaHJpc3RpYW4gTGFtcGFydGVyIDxjaHVua2VleUBnbWFpbC5jb20+CkFja2VkLWJ5OiBKYWNl ayBBbmFzemV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT4KLS0tCkxldCdzIHNlZSBp ZiBsaW51eC11c2IgaXMgc3RpbGwgb24gaG9saWRheSBvciBub3QgOykuCi0tLQogZHJpdmVycy91 c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYyB8IDE3ICsrKysrKysrKystLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3VzYi9jb3JlL2xlZHRyaWctdXNicG9ydC5jIGIvZHJpdmVycy91c2IvY29yZS9sZWR0 cmlnLXVzYnBvcnQuYwppbmRleCBkYzdmN2ZkNzE2ODQuLmMxMmFjNTY2MDZjMyAxMDA2NDQKLS0t IGEvZHJpdmVycy91c2IvY29yZS9sZWR0cmlnLXVzYnBvcnQuYworKysgYi9kcml2ZXJzL3VzYi9j b3JlL2xlZHRyaWctdXNicG9ydC5jCkBAIC0xMTksMTEgKzExOSw2IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgYXR0cmlidXRlX2dyb3VwIHBvcnRzX2dyb3VwID0gewogCS5hdHRycyA9IHBvcnRzX2F0 dHJzLAogfTsKIAotc3RhdGljIGNvbnN0IHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgKnBvcnRzX2dy b3Vwc1tdID0gewotCSZwb3J0c19ncm91cCwKLQlOVUxMCi19OwotCiAvKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqCiAgKiBBZGRpbmcgJiByZW1vdmluZyBwb3J0cwogICoq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KQEAgLTMwNyw2ICszMDIsNyBA QCBzdGF0aWMgaW50IHVzYnBvcnRfdHJpZ19ub3RpZnkoc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpu YiwgdW5zaWduZWQgbG9uZyBhY3Rpb24sCiBzdGF0aWMgaW50IHVzYnBvcnRfdHJpZ19hY3RpdmF0 ZShzdHJ1Y3QgbGVkX2NsYXNzZGV2ICpsZWRfY2RldikKIHsKIAlzdHJ1Y3QgdXNicG9ydF90cmln X2RhdGEgKnVzYnBvcnRfZGF0YTsKKwlpbnQgZXJyOwogCiAJdXNicG9ydF9kYXRhID0ga3phbGxv YyhzaXplb2YoKnVzYnBvcnRfZGF0YSksIEdGUF9LRVJORUwpOwogCWlmICghdXNicG9ydF9kYXRh KQpAQCAtMzE1LDYgKzMxMSw5IEBAIHN0YXRpYyBpbnQgdXNicG9ydF90cmlnX2FjdGl2YXRlKHN0 cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2KQogCiAJLyogTGlzdCBvZiBwb3J0cyAqLwogCUlO SVRfTElTVF9IRUFEKCZ1c2Jwb3J0X2RhdGEtPnBvcnRzKTsKKwllcnIgPSBzeXNmc19jcmVhdGVf Z3JvdXAoJmxlZF9jZGV2LT5kZXYtPmtvYmosICZwb3J0c19ncm91cCk7CisJaWYgKGVycikKKwkJ Z290byBlcnJfZnJlZTsKIAl1c2JfZm9yX2VhY2hfZGV2KHVzYnBvcnRfZGF0YSwgdXNicG9ydF90 cmlnX2FkZF91c2JfZGV2X3BvcnRzKTsKIAl1c2Jwb3J0X3RyaWdfdXBkYXRlX2NvdW50KHVzYnBv cnRfZGF0YSk7CiAKQEAgLTMyMiw4ICszMjEsMTEgQEAgc3RhdGljIGludCB1c2Jwb3J0X3RyaWdf YWN0aXZhdGUoc3RydWN0IGxlZF9jbGFzc2RldiAqbGVkX2NkZXYpCiAJdXNicG9ydF9kYXRhLT5u Yi5ub3RpZmllcl9jYWxsID0gdXNicG9ydF90cmlnX25vdGlmeTsKIAlsZWRfc2V0X3RyaWdnZXJf ZGF0YShsZWRfY2RldiwgdXNicG9ydF9kYXRhKTsKIAl1c2JfcmVnaXN0ZXJfbm90aWZ5KCZ1c2Jw b3J0X2RhdGEtPm5iKTsKLQogCXJldHVybiAwOworCitlcnJfZnJlZToKKwlrZnJlZSh1c2Jwb3J0 X2RhdGEpOworCXJldHVybiBlcnI7CiB9CiAKIHN0YXRpYyB2b2lkIHVzYnBvcnRfdHJpZ19kZWFj dGl2YXRlKHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2KQpAQCAtMzM1LDYgKzMzNyw4IEBA IHN0YXRpYyB2b2lkIHVzYnBvcnRfdHJpZ19kZWFjdGl2YXRlKHN0cnVjdCBsZWRfY2xhc3NkZXYg KmxlZF9jZGV2KQogCQl1c2Jwb3J0X3RyaWdfcmVtb3ZlX3BvcnQodXNicG9ydF9kYXRhLCBwb3J0 KTsKIAl9CiAKKwlzeXNmc19yZW1vdmVfZ3JvdXAoJmxlZF9jZGV2LT5kZXYtPmtvYmosICZwb3J0 c19ncm91cCk7CisKIAl1c2JfdW5yZWdpc3Rlcl9ub3RpZnkoJnVzYnBvcnRfZGF0YS0+bmIpOwog CiAJa2ZyZWUodXNicG9ydF9kYXRhKTsKQEAgLTM0NCw3ICszNDgsNiBAQCBzdGF0aWMgc3RydWN0 IGxlZF90cmlnZ2VyIHVzYnBvcnRfbGVkX3RyaWdnZXIgPSB7CiAJLm5hbWUgICAgID0gInVzYnBv cnQiLAogCS5hY3RpdmF0ZSA9IHVzYnBvcnRfdHJpZ19hY3RpdmF0ZSwKIAkuZGVhY3RpdmF0ZSA9 IHVzYnBvcnRfdHJpZ19kZWFjdGl2YXRlLAotCS5ncm91cHMgPSBwb3J0c19ncm91cHMsCiB9Owog CiBzdGF0aWMgaW50IF9faW5pdCB1c2Jwb3J0X3RyaWdfaW5pdCh2b2lkKQo=