From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>
Subject: USB: serial: ftdi_sio: Fix GPIO not working in autosuspend
Date: Mon, 14 Jan 2019 16:13:48 +0100 [thread overview]
Message-ID: <20190114151348.GJ3691@localhost> (raw)
On Mon, Jan 14, 2019 at 02:48:21PM +0100, Johan Hovold wrote:
> On Mon, Jan 14, 2019 at 01:30:03PM +0100, Karoly Pados wrote:
> > There is a bug in the current GPIO code for ftdi_sio: it failed to take USB
> > autosuspend into account. If the device is in autosuspend, calls to
> > usb_control_msg() fail with -EHOSTUNREACH. Because the standard value for
> > autosuspend timeout is usually 2-5 seconds, this made it almost impossible
> > to use the GPIOs on machines that have USB autosuspend enabled. This patch
> > fixes the issue by acquiring a PM lock on the device for the duration of
> > the USB transfers. Tested on an FT231X device.
> >
> > Signed-off-by: Karoly Pados <pados@pados.hu>
Do you intend to send a corresponding fix for cp210x as well?
Thanks,
Johan
next reply other threads:[~2019-01-14 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 15:13 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-14 13:48 USB: serial: ftdi_sio: Fix GPIO not working in autosuspend Johan Hovold
2019-01-14 12:30 Karoly Pados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114151348.GJ3691@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=pados@pados.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).