* [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
@ 2019-01-16 11:11 Philipp Puschmann
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Puschmann @ 2019-01-16 11:11 UTC (permalink / raw)
To: gregkh
Cc: robh+dt, mark.rutland, Peter.Chen, linux-usb, devicetree,
linux-kernel, Philipp Puschmann
The i.MX6q/dl USB controller may drive the usb power line directly, but the
polarity depends on the board. Reset state of the polarity is low-active so
add this property to allow it to be high-active.
Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
---
Changes in v3: add description
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index adae82385dd6..8696e3eff6e7 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -93,6 +93,7 @@ i.mx specific properties
- over-current-active-low: over current signal polarity is active low.
- over-current-active-high: over current signal polarity is active high.
It's recommended to specify the over current polarity.
+- power-active-high: power signal polarity is high active (only for imx6q/dl)
- external-vbus-divider: enables off-chip resistor divider for Vbus
Example:
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
@ 2019-01-16 19:51 Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-01-16 19:51 UTC (permalink / raw)
To: Philipp Puschmann
Cc: gregkh, robh+dt, mark.rutland, Peter.Chen, linux-usb, devicetree,
linux-kernel
On Wed, 16 Jan 2019 12:11:32 +0100, Philipp Puschmann wrote:
> The i.MX6q/dl USB controller may drive the usb power line directly, but the
> polarity depends on the board. Reset state of the polarity is low-active so
> add this property to allow it to be high-active.
>
> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
> ---
> Changes in v3: add description
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
@ 2019-01-17 7:01 Peter Chen
0 siblings, 0 replies; 5+ messages in thread
From: Peter Chen @ 2019-01-17 7:01 UTC (permalink / raw)
To: Philipp Puschmann, gregkh@linuxfoundation.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
>
> The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity
> depends on the board. Reset state of the polarity is low-active so add this property
> to allow it to be high-active.
>
As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers)
work like this, and most of them are low active for PP default. Would you just use "i.mx" at
both your code and your comment?
Peter
> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
> ---
> Changes in v3: add description
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index adae82385dd6..8696e3eff6e7 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -93,6 +93,7 @@ i.mx specific properties
> - over-current-active-low: over current signal polarity is active low.
> - over-current-active-high: over current signal polarity is active high.
> It's recommended to specify the over current polarity.
> +- power-active-high: power signal polarity is high active (only for
> +imx6q/dl)
> - external-vbus-divider: enables off-chip resistor divider for Vbus
>
> Example:
> --
> 2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
@ 2019-01-21 18:00 Philipp Puschmann
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Puschmann @ 2019-01-21 18:00 UTC (permalink / raw)
To: Peter Chen, Philipp Puschmann, gregkh@linuxfoundation.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Hi Peter,
Am 17.01.19 um 08:01 schrieb Peter Chen:
>
>>
>> The i.MX6q/dl USB controller may drive the usb power line directly, but the polarity
>> depends on the board. Reset state of the polarity is low-active so add this property
>> to allow it to be high-active.
>>
>
> As far as I know, most of i.mx USB controllers (except imx28/23, but they don't have non-core registers)
> work like this, and most of them are low active for PP default. Would you just use "i.mx" at
> both your code and your comment?
Am i right that i have to add my code block to (nearly) all other version specific init functions then?
Will do so in next days and then send a v4 of this patch.
>
> Peter
>
>> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
>> ---
>> Changes in v3: add description
>> ---
>> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> index adae82385dd6..8696e3eff6e7 100644
>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> @@ -93,6 +93,7 @@ i.mx specific properties
>> - over-current-active-low: over current signal polarity is active low.
>> - over-current-active-high: over current signal polarity is active high.
>> It's recommended to specify the over current polarity.
>> +- power-active-high: power signal polarity is high active (only for
>> +imx6q/dl)
>> - external-vbus-divider: enables off-chip resistor divider for Vbus
>>
>> Example:
>> --
>> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high
@ 2019-01-22 7:50 Peter Chen
0 siblings, 0 replies; 5+ messages in thread
From: Peter Chen @ 2019-01-22 7:50 UTC (permalink / raw)
To: Philipp Puschmann, Philipp Puschmann, gregkh@linuxfoundation.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> Am 17.01.19 um 08:01 schrieb Peter Chen:
> >
> >>
> >> The i.MX6q/dl USB controller may drive the usb power line directly,
> >> but the polarity depends on the board. Reset state of the polarity is
> >> low-active so add this property to allow it to be high-active.
> >>
> >
> > As far as I know, most of i.mx USB controllers (except imx28/23, but
> > they don't have non-core registers) work like this, and most of them
> > are low active for PP default. Would you just use "i.mx" at both your code and
> your comment?
>
> Am i right that i have to add my code block to (nearly) all other version specific init
> functions then?
Besides your current patch, only usbmisc_imx7d_init is needed to add the same content.
Peter
> Will do so in next days and then send a v4 of this patch.
> >
> > Peter
> >
> >> Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
> >> ---
> >> Changes in v3: add description
> >> ---
> >> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> index adae82385dd6..8696e3eff6e7 100644
> >> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> >> @@ -93,6 +93,7 @@ i.mx specific properties
> >> - over-current-active-low: over current signal polarity is active low.
> >> - over-current-active-high: over current signal polarity is active high.
> >> It's recommended to specify the over current polarity.
> >> +- power-active-high: power signal polarity is high active (only for
> >> +imx6q/dl)
> >> - external-vbus-divider: enables off-chip resistor divider for Vbus
> >>
> >> Example:
> >> --
> >> 2.20.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-22 7:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 19:51 [v3,1/2] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-01-22 7:50 Peter Chen
2019-01-21 18:00 Philipp Puschmann
2019-01-17 7:01 Peter Chen
2019-01-16 11:11 Philipp Puschmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).