From: Greg KH <greg@kroah.com>
To: Ajay Gupta <ajayg@nvidia.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org
Subject: [5/7] usb: typec: ucsi: add fw update needed check
Date: Fri, 18 Jan 2019 08:07:13 +0100 [thread overview]
Message-ID: <20190118070713.GC11050@kroah.com> (raw)
On Thu, Jan 17, 2019 at 05:12:38PM -0800, Ajay Gupta wrote:
> This will be needed to check if latest fw is already flashed.
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 139 ++++++++++++++++++++++++++++++
> 1 file changed, 139 insertions(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 5f341934a5af..6069a9f60d1e 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -9,6 +9,7 @@
> */
> #include <linux/acpi.h>
> #include <linux/delay.h>
> +#include <linux/firmware.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> @@ -17,6 +18,8 @@
> #include <asm/unaligned.h>
> #include "ucsi.h"
>
> +static int secondary_fw_min_ver = 41;
> +module_param(secondary_fw_min_ver, int, 0660);
Ick, never add new module parameters, this isn't the 1990's :)
next reply other threads:[~2019-01-18 7:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 7:07 Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-24 18:01 [5/7] usb: typec: ucsi: add fw update needed check Ajay Gupta
2019-01-24 17:54 Ajay Gupta
2019-01-24 17:47 Ajay Gupta
2019-01-18 15:37 Heikki Krogerus
2019-01-18 7:06 Greg Kroah-Hartman
2019-01-18 1:12 Ajay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118070713.GC11050@kroah.com \
--to=greg@kroah.com \
--cc=ajayg@nvidia.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).