* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-01-21 12:22 min.guo
0 siblings, 0 replies; 6+ messages in thread
From: min.guo @ 2019-01-21 12:22 UTC (permalink / raw)
To: Bin Liu, Rob Herring
Cc: Greg Kroah-Hartman, Mark Rutland, Matthias Brugger, Alan Stern,
chunfeng.yun, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, tony, hdegoede, Min Guo
From: Min Guo <min.guo@mediatek.com>
This adds support for MediaTek musb controller in
host, peripheral and otg mode.
Signed-off-by: Min Guo <min.guo@mediatek.com>
---
changes in v4:
suggested by Sergei:
1. String alignment
changes in v3:
1. no changes
changes in v2:
suggested by Bin:
1. Modify DRC to DRD
suggested by Rob:
2. Drop the "<soc-model>-musb" in compatible
3. Remove phy-names
4. Add space after comma in clock-names
---
.../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
new file mode 100644
index 0000000..4305770
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
@@ -0,0 +1,43 @@
+MediaTek musb DRD/OTG controller
+-------------------------------------------
+
+Required properties:
+ - compatible : should be "mediatek,mtk-musb"
+ - reg : specifies physical base address and size of
+ the registers
+ - interrupts : interrupt used by musb controller
+ - interrupt-names : must be "mc"
+ - phys : PHY specifier for the OTG phy
+ - dr_mode : should be one of "host", "peripheral" or "otg",
+ refer to usb/generic.txt
+ - clocks : a list of phandle + clock-specifier pairs, one for
+ each entry in clock-names
+ - clock-names : must contain "main", "mcu", "univpll"
+ for clocks of controller
+
+Optional properties:
+ - extcon : external connector for VBUS and ID pin changes detection,
+ needed when supports dual-role mode
+ - vbus-supply : reference to the VBUS regulator, needed when supports
+ dual-role mode
+ - power-domains : a phandle to USB power domain node to control USB's
+ MTCMOS
+
+Example:
+
+usb2: usb@11200000 {
+ compatible = "mediatek,mt2701-musb",
+ "mediatek,mtk-musb";
+ reg = <0 0x11200000 0 0x1000>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "mc";
+ phys = <&u2port2 PHY_TYPE_USB2>;
+ vbus-supply = <&usb_vbus>;
+ extcon = <&extcon_usb>;
+ dr_mode = "otg";
+ clocks = <&pericfg CLK_PERI_USB0>,
+ <&pericfg CLK_PERI_USB0_MCU>,
+ <&pericfg CLK_PERI_USB_SLV>;
+ clock-names = "main","mcu","univpll";
+ power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
+};
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-01-21 15:14 Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-01-21 15:14 UTC (permalink / raw)
To: min.guo
Cc: Bin Liu, Mark Rutland, devicetree, hdegoede, tony,
Greg Kroah-Hartman, linux-usb, linux-kernel, Matthias Brugger,
Alan Stern, chunfeng.yun, linux-mediatek, linux-arm-kernel
On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote:
> From: Min Guo <min.guo@mediatek.com>
>
> This adds support for MediaTek musb controller in
> host, peripheral and otg mode.
>
> Signed-off-by: Min Guo <min.guo@mediatek.com>
> ---
> changes in v4:
> suggested by Sergei:
> 1. String alignment
>
> changes in v3:
> 1. no changes
>
> changes in v2:
> suggested by Bin:
> 1. Modify DRC to DRD
> suggested by Rob:
> 2. Drop the "<soc-model>-musb" in compatible
This is not what I said. I gave you the exact text to put.
> 3. Remove phy-names
> 4. Add space after comma in clock-names
> ---
> .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> new file mode 100644
> index 0000000..4305770
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> @@ -0,0 +1,43 @@
> +MediaTek musb DRD/OTG controller
> +-------------------------------------------
> +
> +Required properties:
> + - compatible : should be "mediatek,mtk-musb"
> + - reg : specifies physical base address and size of
> + the registers
> + - interrupts : interrupt used by musb controller
> + - interrupt-names : must be "mc"
> + - phys : PHY specifier for the OTG phy
> + - dr_mode : should be one of "host", "peripheral" or "otg",
> + refer to usb/generic.txt
> + - clocks : a list of phandle + clock-specifier pairs, one for
> + each entry in clock-names
> + - clock-names : must contain "main", "mcu", "univpll"
> + for clocks of controller
> +
> +Optional properties:
> + - extcon : external connector for VBUS and ID pin changes detection,
> + needed when supports dual-role mode
Again, do not use extcon in new bindings.
> + - vbus-supply : reference to the VBUS regulator, needed when supports
> + dual-role mode
> + - power-domains : a phandle to USB power domain node to control USB's
> + MTCMOS
> +
> +Example:
> +
> +usb2: usb@11200000 {
> + compatible = "mediatek,mt2701-musb",
> + "mediatek,mtk-musb";
> + reg = <0 0x11200000 0 0x1000>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "mc";
> + phys = <&u2port2 PHY_TYPE_USB2>;
> + vbus-supply = <&usb_vbus>;
> + extcon = <&extcon_usb>;
> + dr_mode = "otg";
> + clocks = <&pericfg CLK_PERI_USB0>,
> + <&pericfg CLK_PERI_USB0_MCU>,
> + <&pericfg CLK_PERI_USB_SLV>;
> + clock-names = "main","mcu","univpll";
> + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
> +};
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-01-22 9:36 min.guo
0 siblings, 0 replies; 6+ messages in thread
From: min.guo @ 2019-01-22 9:36 UTC (permalink / raw)
To: Rob Herring, Bin Liu
Cc: Mark Rutland, devicetree, hdegoede, tony, Greg Kroah-Hartman,
linux-usb, linux-kernel, Matthias Brugger, Alan Stern,
chunfeng.yun, linux-mediatek, linux-arm-kernel
Hi Bin,
Sorry to bother you again, I encounter a problem about the extcon
property.
I don't find a common driver describing the usb-connector. Is
there any driver that I can refer to, specially the way to switch MUSB
controller between host and device mode?
If it needs to implement by myself, is it possible to emulate an
usb-connector driver by extcon-usb-gpio, and also use the notifier
mechanism or can you give me some advices?
Hi Rob,
On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote:
> On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote:
> > From: Min Guo <min.guo@mediatek.com>
> >
> > This adds support for MediaTek musb controller in
> > host, peripheral and otg mode.
> >
> > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > ---
> > changes in v4:
> > suggested by Sergei:
> > 1. String alignment
> >
> > changes in v3:
> > 1. no changes
> >
> > changes in v2:
> > suggested by Bin:
> > 1. Modify DRC to DRD
> > suggested by Rob:
> > 2. Drop the "<soc-model>-musb" in compatible
>
> This is not what I said. I gave you the exact text to put.
Sorry to misunderstood your meaning last time, I will modify it in next
patch.
compatible: should be one of "mediatek,mt2701-musb"...,followed by
"mediatek,mtk-musb"
> > 3. Remove phy-names
> > 4. Add space after comma in clock-names
> > ---
> > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > new file mode 100644
> > index 0000000..4305770
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > @@ -0,0 +1,43 @@
> > +MediaTek musb DRD/OTG controller
> > +-------------------------------------------
> > +
> > +Required properties:
> > + - compatible : should be "mediatek,mtk-musb"
> > + - reg : specifies physical base address and size of
> > + the registers
> > + - interrupts : interrupt used by musb controller
> > + - interrupt-names : must be "mc"
> > + - phys : PHY specifier for the OTG phy
> > + - dr_mode : should be one of "host", "peripheral" or "otg",
> > + refer to usb/generic.txt
> > + - clocks : a list of phandle + clock-specifier pairs, one for
> > + each entry in clock-names
> > + - clock-names : must contain "main", "mcu", "univpll"
> > + for clocks of controller
> > +
> > +Optional properties:
> > + - extcon : external connector for VBUS and ID pin changes detection,
> > + needed when supports dual-role mode
>
> Again, do not use extcon in new bindings.
Thanks, ok.
> > + - vbus-supply : reference to the VBUS regulator, needed when supports
> > + dual-role mode
> > + - power-domains : a phandle to USB power domain node to control USB's
> > + MTCMOS
> > +
> > +Example:
> > +
> > +usb2: usb@11200000 {
> > + compatible = "mediatek,mt2701-musb",
> > + "mediatek,mtk-musb";
> > + reg = <0 0x11200000 0 0x1000>;
> > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-names = "mc";
> > + phys = <&u2port2 PHY_TYPE_USB2>;
> > + vbus-supply = <&usb_vbus>;
> > + extcon = <&extcon_usb>;
> > + dr_mode = "otg";
> > + clocks = <&pericfg CLK_PERI_USB0>,
> > + <&pericfg CLK_PERI_USB0_MCU>,
> > + <&pericfg CLK_PERI_USB_SLV>;
> > + clock-names = "main","mcu","univpll";
> > + power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
> > +};
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Regards,
Min.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-01-22 14:33 Bin Liu
0 siblings, 0 replies; 6+ messages in thread
From: Bin Liu @ 2019-01-22 14:33 UTC (permalink / raw)
To: Min Guo
Cc: Rob Herring, Mark Rutland, devicetree, hdegoede, tony,
Greg Kroah-Hartman, linux-usb, linux-kernel, Matthias Brugger,
Alan Stern, chunfeng.yun, linux-mediatek, linux-arm-kernel
Hi Min,
On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> Hi Bin,
>
> Sorry to bother you again, I encounter a problem about the extcon
> property.
>
> I don't find a common driver describing the usb-connector. Is
> there any driver that I can refer to, specially the way to switch MUSB
> controller between host and device mode?
> If it needs to implement by myself, is it possible to emulate an
> usb-connector driver by extcon-usb-gpio, and also use the notifier
> mechanism or can you give me some advices?
I am afraid I am unable to help you on this. I wasn't really pay
attention when usb-connector was introduced and not sure how it can
replace extcon. Now after read usb-connector.txt, it seems the binding
only defines a/b/c-connector, but not ab-connector, and there is no
enough information (at least for me) explaining how VBUS and ID fix into
this usb-connector binding.
Maybe Rob can provide some hint.
Regards,
-Bin.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-01-25 2:07 min.guo
0 siblings, 0 replies; 6+ messages in thread
From: min.guo @ 2019-01-25 2:07 UTC (permalink / raw)
To: Bin Liu, Rob Herring
Cc: Mark Rutland, devicetree, hdegoede, tony, Greg Kroah-Hartman,
linux-usb, linux-kernel, Matthias Brugger, Alan Stern,
chunfeng.yun, linux-mediatek, linux-arm-kernel
Hi Bin,
Thanks for your help.
Hi Rob,
I find that Samsung describes the usb-connector attribute in DTS, and
uses a private driver.
And try to write DTS as following:
usb-connector node:
musb_con: musb_connector{
compatible = "linux,extcon-usb-gpio","usb-b-connector";
lable = "micro-USB";
type = "micro";
id-gpio = <&pio 44 GPIO_ACTIVE_HIGH>
vbus-supply = <&usb_vbus>;
port {
usb_to_connector: endpoint {
remote-endpoint = <&connector_to_usb>;
};
};
};
usb node:
&usb2{
status = "okay";
port {
connector_to_usb: endpoint {
remote-endpoint = <&usb_to_connector>;
};
};
}
Can I describe usb-connector like this? Or can you give me some advices?
Regards,
Min.
On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote:
> Hi Min,
>
> On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> > Hi Bin,
> >
> > Sorry to bother you again, I encounter a problem about the extcon
> > property.
> >
> > I don't find a common driver describing the usb-connector. Is
> > there any driver that I can refer to, specially the way to switch MUSB
> > controller between host and device mode?
> > If it needs to implement by myself, is it possible to emulate an
> > usb-connector driver by extcon-usb-gpio, and also use the notifier
> > mechanism or can you give me some advices?
>
> I am afraid I am unable to help you on this. I wasn't really pay
> attention when usb-connector was introduced and not sure how it can
> replace extcon. Now after read usb-connector.txt, it seems the binding
> only defines a/b/c-connector, but not ab-connector, and there is no
> enough information (at least for me) explaining how VBUS and ID fix into
> this usb-connector binding.
>
> Maybe Rob can provide some hint.
>
> Regards,
> -Bin.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
@ 2019-02-14 8:30 min.guo
0 siblings, 0 replies; 6+ messages in thread
From: min.guo @ 2019-02-14 8:30 UTC (permalink / raw)
To: Rob Herring
Cc: Bin Liu, Mark Rutland, devicetree, hdegoede, tony,
Greg Kroah-Hartman, linux-usb, linux-kernel, Matthias Brugger,
Alan Stern, chunfeng.yun, linux-mediatek, linux-arm-kernel
Hi Rob,
Sorry to bother you again.
Can I describe usb-connector in usb node like this?
usb2: usb@11200000 {
compatible = "mediatek,mt2701-musb";
"mediatek,mtk-musb";
reg = <0 0x11200000 0 0x1000>;
...
usb_connector: musb_connector {
compatible = "usb-b-connector";
label = "micro-USB";
type = "micro";
extcon = <&extcon_usb>;
vbus-supply = <&usb_vbus>;
};
};
Regards,
Min.
On Fri, 2019-01-25 at 10:07 +0800, Min Guo wrote:
> Hi Bin,
>
> Thanks for your help.
>
> Hi Rob,
>
> I find that Samsung describes the usb-connector attribute in DTS, and
> uses a private driver.
> And try to write DTS as following:
>
> usb-connector node:
> musb_con: musb_connector{
> compatible = "linux,extcon-usb-gpio","usb-b-connector";
> lable = "micro-USB";
> type = "micro";
> id-gpio = <&pio 44 GPIO_ACTIVE_HIGH>
> vbus-supply = <&usb_vbus>;
> port {
> usb_to_connector: endpoint {
> remote-endpoint = <&connector_to_usb>;
> };
> };
> };
>
> usb node:
> &usb2{
> status = "okay";
> port {
> connector_to_usb: endpoint {
> remote-endpoint = <&usb_to_connector>;
> };
> };
> }
>
> Can I describe usb-connector like this? Or can you give me some advices?
>
> Regards,
> Min.
>
> On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote:
> > Hi Min,
> >
> > On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> > > Hi Bin,
> > >
> > > Sorry to bother you again, I encounter a problem about the extcon
> > > property.
> > >
> > > I don't find a common driver describing the usb-connector. Is
> > > there any driver that I can refer to, specially the way to switch MUSB
> > > controller between host and device mode?
> > > If it needs to implement by myself, is it possible to emulate an
> > > usb-connector driver by extcon-usb-gpio, and also use the notifier
> > > mechanism or can you give me some advices?
> >
> > I am afraid I am unable to help you on this. I wasn't really pay
> > attention when usb-connector was introduced and not sure how it can
> > replace extcon. Now after read usb-connector.txt, it seems the binding
> > only defines a/b/c-connector, but not ab-connector, and there is no
> > enough information (at least for me) explaining how VBUS and ID fix into
> > this usb-connector binding.
> >
> > Maybe Rob can provide some hint.
> >
> > Regards,
> > -Bin.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-14 8:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-22 14:33 [v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2019-02-14 8:30 min.guo
2019-01-25 2:07 min.guo
2019-01-22 9:36 min.guo
2019-01-21 15:14 Rob Herring
2019-01-21 12:22 min.guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).