From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laura Abbott <labbott@redhat.com>,
Alexander Popov <alex.popov@linux.com>,
xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, dev@openvswitch.org,
linux-kbuild@vger.kernel.org,
linux-security-module@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [1/3] treewide: Lift switch variables out of switches
Date: Wed, 23 Jan 2019 12:58:29 +0100 [thread overview]
Message-ID: <20190123115829.GA31385@kroah.com> (raw)
On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote:
> Variables declared in a switch statement before any case statements
> cannot be initialized, so move all instances out of the switches.
> After this, future always-initialized stack variables will work
> and not throw warnings like this:
>
> fs/fcntl.c: In function ‘send_sigio_to_task’:
> fs/fcntl.c:738:13: warning: statement will never be executed [-Wswitch-unreachable]
> siginfo_t si;
> ^~
That's a pain, so this means we can't have any new variables in { }
scope except for at the top of a function?
That's going to be a hard thing to keep from happening over time, as
this is valid C :(
greg k-h
next reply other threads:[~2019-01-23 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 11:58 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-24 12:58 [1/3] treewide: Lift switch variables out of switches Edwin Zimmerman
2019-01-24 8:10 Greg Kroah-Hartman
2019-01-23 20:36 Kees Cook
2019-01-23 19:18 Matthew Wilcox
2019-01-23 18:55 Kees Cook
2019-01-23 16:51 Jeff Kirsher
2019-01-23 15:46 Jani Nikula
2019-01-23 14:47 Edwin Zimmerman
2019-01-23 14:23 Jani Nikula
2019-01-23 14:17 Jani Nikula
2019-01-23 13:21 William Kucharski
2019-01-23 12:12 Ard Biesheuvel
2019-01-23 12:09 Jann Horn
2019-01-23 11:03 Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123115829.GA31385@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.popov@linux.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dev@openvswitch.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).