From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] usb: ftdi-elan: Fix if == else warnings in ftdi_elan_respond_engine From: Greg Kroah-Hartman Message-Id: <20190123134147.GC24700@kroah.com> Date: Wed, 23 Jan 2019 14:41:48 +0100 To: YueHaibing Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMjMsIDIwMTkgYXQgMDk6MTc6MzhQTSArMDgwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBPbiAyMDE5LzEvMjMgMjA6NDMsIEdyZWcgS0ggd3JvdGU6Cj4gPiBPbiBXZWQsIEphbiAy MywgMjAxOSBhdCAwODozNDo0MlBNICswODAwLCBZdWVIYWliaW5nIHdyb3RlOgo+ID4+IC4vZHJp dmVycy91c2IvbWlzYy9mdGRpLWVsYW4uYzo5NzI6MTAtMTI6IFdBUk5JTkc6IHBvc3NpYmxlIGNv bmRpdGlvbiB3aXRoIG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkKPiA+PiAuL2RyaXZlcnMvdXNiL21p c2MvZnRkaS1lbGFuLmM6OTgzOjktMTE6IFdBUk5JTkc6IHBvc3NpYmxlIGNvbmRpdGlvbiB3aXRo IG5vIGVmZmVjdCAoaWYgPT0gZWxzZSkKPiA+PiAuL2RyaXZlcnMvdXNiL21pc2MvZnRkaS1lbGFu LmM6MjA1MjoxMS0xMzogV0FSTklORzogcG9zc2libGUgY29uZGl0aW9uIHdpdGggbm8gZWZmZWN0 IChpZiA9PSBlbHNlKQo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFp YmluZ0BodWF3ZWkuY29tPgo+ID4gCj4gPiBZb3UgY2FuIG5vdCBqdXN0IHByb3ZpZGUgdGhlIG91 dHB1dCBvZiBhIHRvb2wgYXMgYSBjaGFuZ2Vsb2cgdGV4dCwKPiA+IHNvcnJ5Lgo+ID4gCj4gPiBQ bGVhc2UgZXhwbGFpbiB3aGF0IHRob3NlIGxpbmVzIG1lYW4sIGFuZCB3aHkgeW91IGFyZSBtYWtp bmcgdGhlIGNoYW5nZQo+ID4gdGhhdCB5b3UgYXJlLgo+IAo+IG9rLCB3aWxsIGRvIHRoYXQuCj4g Cj4gPiAKPiA+PiAtLS0KPiA+PiAgZHJpdmVycy91c2IvbWlzYy9mdGRpLWVsYW4uYyB8IDI2IC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBkZWxldGlv bnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9taXNjL2Z0ZGktZWxhbi5j IGIvZHJpdmVycy91c2IvbWlzYy9mdGRpLWVsYW4uYwo+ID4+IGluZGV4IDc2YzcxOGEuLjI1N2Vm YWMgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy91c2IvbWlzYy9mdGRpLWVsYW4uYwo+ID4+ICsr KyBiL2RyaXZlcnMvdXNiL21pc2MvZnRkaS1lbGFuLmMKPiA+PiBAQCAtOTE1LDcgKzkxNSw2IEBA IHN0YXRpYyBpbnQgZnRkaV9lbGFuX3Jlc3BvbmRfZW5naW5lKHN0cnVjdCB1c2JfZnRkaSAqZnRk aSkKPiA+PiAgCWludCBieXRlc19yZWFkID0gMDsKPiA+PiAgCWludCByZXRyeV9vbl9lbXB0eSA9 IDE7Cj4gPj4gIAlpbnQgcmV0cnlfb25fdGltZW91dCA9IDM7Cj4gPj4gLQlpbnQgZW1wdHlfcGFj a2V0cyA9IDA7Cj4gPj4gIHJlYWQ6ewo+ID4+ICAJCWludCBwYWNrZXRfYnl0ZXMgPSAwOwo+ID4+ ICAJCWludCByZXR2YWwgPSB1c2JfYnVsa19tc2coZnRkaS0+dWRldiwKPiA+PiBAQCAtOTYwLDMx ICs5NTksNiBAQCByZWFkOnsKPiA+PiAgCQkJZGV2X2VycigmZnRkaS0+dWRldi0+ZGV2LCAiZXJy b3IgPSAlZCB3aXRoIHBhY2tldF9ieXRlcyA9ICVkIHdpdGggdG90YWwgJWQgYnl0ZXMlc1xuIiwK PiA+PiAgCQkJCXJldHZhbCwgcGFja2V0X2J5dGVzLCBieXRlc19yZWFkLCBkaWFnKTsKPiA+PiAg CQkJcmV0dXJuIHJldHZhbDsKPiA+PiAtCQl9IGVsc2UgaWYgKHBhY2tldF9ieXRlcyA9PSAyKSB7 Cj4gPj4gLQkJCXVuc2lnbmVkIGNoYXIgczAgPSBmdGRpLT5idWxrX2luX2J1ZmZlclswXTsKPiA+ PiAtCQkJdW5zaWduZWQgY2hhciBzMSA9IGZ0ZGktPmJ1bGtfaW5fYnVmZmVyWzFdOwo+ID4+IC0J CQllbXB0eV9wYWNrZXRzICs9IDE7Cj4gPj4gLQkJCWlmIChzMCA9PSAweDMxICYmIHMxID09IDB4 NjApIHsKPiA+PiAtCQkJCWlmIChyZXRyeV9vbl9lbXB0eS0tID4gMCkgewo+ID4+IC0JCQkJCWdv dG8gbW9yZTsKPiA+PiAtCQkJCX0gZWxzZQo+ID4+IC0JCQkJCXJldHVybiAwOwo+ID4+IC0JCQl9 IGVsc2UgaWYgKHMwID09IDB4MzEgJiYgczEgPT0gMHgwMCkgewo+ID4+IC0JCQkJaWYgKHJldHJ5 X29uX2VtcHR5LS0gPiAwKSB7Cj4gPj4gLQkJCQkJZ290byBtb3JlOwo+ID4+IC0JCQkJfSBlbHNl Cj4gPj4gLQkJCQkJcmV0dXJuIDA7Cj4gPj4gLQkJCX0gZWxzZSB7Cj4gPj4gLQkJCQlpZiAocmV0 cnlfb25fZW1wdHktLSA+IDApIHsKPiA+PiAtCQkJCQlnb3RvIG1vcmU7Cj4gPj4gLQkJCQl9IGVs c2UKPiA+PiAtCQkJCQlyZXR1cm4gMDsKPiA+PiAtCQkJfQo+ID4+IC0JCX0gZWxzZSBpZiAocGFj a2V0X2J5dGVzID09IDEpIHsKPiA+PiAtCQkJaWYgKHJldHJ5X29uX2VtcHR5LS0gPiAwKSB7Cj4g Pj4gLQkJCQlnb3RvIG1vcmU7Cj4gPj4gLQkJCX0gZWxzZQo+ID4+IC0JCQkJcmV0dXJuIDA7Cj4g PiAKPiA+IEFyZSB5b3UgX3N1cmVfIHRoYXQgdGhlc2UgbGluZXMgYXJlIG5vdCBuZWVkZWQgYW5k IHRoYXQgdGhlIGNvbXBpbGVyIGlzCj4gPiBub3QgcmVhbGx5IHNlZWluZyB0aGVtPyAgQXMgaXQg ZG9lc24ndCBsb29rIHRoYXQgd2F5IHRvIG1lLCB3aGF0IGFtIEkKPiA+IG1pc3Npbmc/Cj4gCj4g SSBjaGVja2VkIGFuZCBtYWtlIHN1cmUgdGhhdCBBbGwgdGhlc2UgaWYvZWxzZSBpZiBicmFuY2gg anVzdCBkbyB0aGUgc2FtZSB0aGluZzoKPiAKPiAJaWYgKHJldHJ5X29uX2VtcHR5LS0gPiAwKSB7 Cj4gCQlnb3RvIG1vcmU7Cj4gCX0gZWxzZQo+IAkJcmV0dXJuIDA7Cj4gCj4gc28gaXQgY2FuIGJl IG1lcmdlZCBpbnRvIHRoZSBsYXN0IGVsc2UgYnJhbmNoLgo+IAo+IEFsc28gdGhlIHZhcmlhYmxl ICdlbXB0eV9wYWNrZXRzJyBkb2Vzbid0IHVzZSBpbiBhbnkgcGxhY2UsIGV4Y2VwdCBmb3Igc2Vs ZiBpbmNyZW1lbnQKCkRvbid0IGRvIHR3byBkaWZmZXJlbnQgdGhpbmdzIGluIHRoZSBzYW1lIHBh dGNoIDopCg==