From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>
Subject: [v2] USB: serial: cp210x: Fix GPIO in autosuspend
Date: Wed, 20 Feb 2019 10:23:04 +0100 [thread overview]
Message-ID: <20190220092304.GG4072@localhost> (raw)
On Sun, Feb 17, 2019 at 06:59:01PM +0100, Karoly Pados wrote:
> Current GPIO code in cp210x fails to take USB autosuspend into account,
> making it practically impossible to use GPIOs with autosuspend enabled
> without user configuration. Fix this like for ftdi_sio in a previous patch.
> Tested on a CP2102N.
>
> Signed-off-by: Karoly Pados <pados@pados.hu>
> ---
> Changelog:
> - v2: Restrict new autopm calls to GPIO paths.
> Always check result of usb_autopm_get.
> Rebased to current usb_serial upstream.
Thanks for the v2. Now applied after removing the unmotivated white
space change.
I also added a Fixes and CC-stable tag as this seems annoying enough to
warrant a backport even if autosuspend was never actually supported.
Johan
next reply other threads:[~2019-02-20 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 9:23 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-20 9:11 [v2] USB: serial: cp210x: Fix GPIO in autosuspend Johan Hovold
2019-03-19 17:19 Karoly Pados
2019-03-19 17:12 Karoly Pados
2019-03-19 13:14 Johan Hovold
2019-03-19 11:15 Oliver Neukum
2019-03-19 10:36 Johan Hovold
2019-02-18 9:17 Oliver Neukum
2019-02-17 17:59 Karoly Pados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220092304.GG4072@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=pados@pados.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).