From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jean-Philippe Menil <jpmenil@gmail.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>, linux-usb@vger.kernel.org
Subject: [1/4] usb: xhci: fix build warning - missing prototype
Date: Thu, 21 Feb 2019 10:49:36 +0100 [thread overview]
Message-ID: <20190221094935.GA618@kroah.com> (raw)
On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote:
> On Thu, 21 Feb 2019, Greg KH wrote:
>
> > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote:
> > > On Wed, 20 Feb 2019, Greg KH wrote:
> > >
> > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote:
> > > > > From: Jean-Philippe Menil <jpmenil@gmail.com>
> > > > >
> > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing
> > > > > prototype for xhci_free_virt_devices_depth_first.
> > > >
> > > > There is no normal "build warning", this is a sparse fixup, right?
> > > >
> > > >
> > >
> > > Hi Greg,
> > >
> > > this is a build warning, at least with W=1 :
> > >
> > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for
> > > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes]
> > > void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int
> > > slot_id)
> >
> > "W=1" is not a normal build option for anyone to use, except those that
> > wish to find crazy issues like this :)
> >
> > Also, if that is the only way it shows up, you should mention it in the
> > changelog.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Hmm, rereaind this mail from kernel-janitors
> https://marc.info/?l=kernel-janitors&m=154178546220848&w=2
> seem that you're right, this is not a normal option :)
>
> Mathias, do you want me to re-send something?
No need, I'll go edit the changelog text...
greg k-h
next reply other threads:[~2019-02-21 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 9:49 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-21 9:52 [1/4] usb: xhci: fix build warning - missing prototype Jean-Philippe Menil
2019-02-21 9:39 Jean-Philippe Menil
2019-02-21 8:41 Greg Kroah-Hartman
2019-02-20 20:54 Jean-Philippe Menil
2019-02-20 19:17 Greg Kroah-Hartman
2019-02-20 18:44 Greg Kroah-Hartman
2019-02-20 18:01 Mathias Nyman
2019-02-20 17:50 Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221094935.GA618@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jpmenil@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).