From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Chen <peter.chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device()
Date: Mon, 25 Feb 2019 08:07:15 +0300 [thread overview]
Message-ID: <20190225080715.4965810a@dimatab> (raw)
В Mon, 25 Feb 2019 02:27:19 +0000
Peter Chen <peter.chen@nxp.com> пишет:
>
> >
> > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for
> > Tegra20/30/114/124")
>
> I suppose you need to apply at stable tree too, right?
>
It is enough to have the "Fixes" tag to get patch backported into all
relevant kernel versions.
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > ---
> > drivers/usb/chipidea/ci_hdrc_tegra.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > index 772851bee99b..12025358bb3c 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct
> > platform_device *pdev) {
> > struct tegra_udc *udc = platform_get_drvdata(pdev);
> >
> > + ci_hdrc_remove_device(udc->dev);
> > usb_phy_set_suspend(udc->phy, 1);
> > clk_disable_unprepare(udc->clk);
> >
>
> Acked-by: Peter Chen <peter.chen@nxp.com>
>
> Hi Greg, would you still accept the bug-fix for this release (v5.0)?
> Or I send you later?
I just want to point out that the bug existed for a very long time and
apparently didn't bother anybody, hence it's not an urgent fix.
next reply other threads:[~2019-02-25 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 5:07 Dmitry Osipenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-26 15:40 [v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove_device() Dmitry Osipenko
2019-02-26 15:21 Greg Kroah-Hartman
2019-02-26 15:08 Dmitry Osipenko
2019-02-26 14:58 Greg Kroah-Hartman
2019-02-26 14:33 Dmitry Osipenko
2019-02-26 10:56 Greg Kroah-Hartman
2019-02-25 2:27 Peter Chen
2019-02-24 15:36 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225080715.4965810a@dimatab \
--to=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).