From: Thierry Reding <thierry.reding@gmail.com>
To: Nagarjuna Kristam <nkristam@nvidia.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: [1/8] phy: tegra: xusb: t210: add XUSB device mode support
Date: Mon, 25 Feb 2019 13:23:07 +0100 [thread overview]
Message-ID: <20190225122307.GA11196@ulmo> (raw)
On Fri, Feb 15, 2019 at 11:48:37AM +0530, Nagarjuna Kristam wrote:
>
>
> On 13-02-2019 12:34, Nagarjuna Kristam wrote:
> >>> EXPORT_SYMBOL_GPL(tegra_xusb_padctl_usb3_set_lfps_detect);
> >>>
> >>> +int tegra_xusb_padctl_set_vbus_override(struct tegra_xusb_padctl *padctl)
> >>> +{
> >>> + if (padctl->soc->ops->vbus_override)
> >>> + return padctl->soc->ops->vbus_override(padctl, true);
> >>> +
> >>> + return -EINVAL;
> >> It'd be best to stick to the -ENOSYS error code here.
> >>
> > will do
> >
> Using ENOSYS is marked as checkpatch warning
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>
> I suggest to use ENOTSUP instead of EINVAL/ENOSYS.
Sounds good to me.
Thierry
next reply other threads:[~2019-02-25 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 12:23 Thierry Reding [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-15 6:18 [1/8] phy: tegra: xusb: t210: add XUSB device mode support Nagarjuna Kristam
2019-02-13 8:35 Thierry Reding
2019-02-13 7:04 Nagarjuna Kristam
2019-02-13 6:47 Nagarjuna Kristam
2019-02-04 12:27 Thierry Reding
2019-01-03 10:04 Nagarjuna Kristam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225122307.GA11196@ulmo \
--to=thierry.reding@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkristam@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).