* [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property
@ 2019-02-05 6:18 Srinath Mannam
0 siblings, 0 replies; 5+ messages in thread
From: Srinath Mannam @ 2019-02-05 6:18 UTC (permalink / raw)
To: Greg Kroah-Hartman, Mathias Nyman, Rob Herring, Mark Rutland
Cc: linux-usb, devicetree, linux-kernel, Srinath Mannam
Add usb-phy-port-reset optional property to set quirk in xhci platform
driver which forces USB port PHY reset on port disconnect event.
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
---
Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index fea8b15..ecbdb15 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -40,6 +40,7 @@ Optional properties:
- usb3-lpm-capable: determines if platform is USB3 LPM capable
- quirk-broken-port-ped: set if the controller has broken port disable mechanism
- imod-interval-ns: default interrupt moderation interval is 5000ns
+ - usb-phy-port-reset: set this to do USB PORT PHY reset while disconnect
- phys : see usb-hcd.txt in the current directory
additionally the properties from usb-hcd.txt (in the current directory) are
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property
@ 2019-02-25 21:38 Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-02-25 21:38 UTC (permalink / raw)
To: Srinath Mannam
Cc: Greg Kroah-Hartman, Mathias Nyman, Mark Rutland, linux-usb,
devicetree, linux-kernel
On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote:
> Add usb-phy-port-reset optional property to set quirk in xhci platform
> driver which forces USB port PHY reset on port disconnect event.
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> ---
> Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index fea8b15..ecbdb15 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -40,6 +40,7 @@ Optional properties:
> - usb3-lpm-capable: determines if platform is USB3 LPM capable
> - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> - imod-interval-ns: default interrupt moderation interval is 5000ns
> + - usb-phy-port-reset: set this to do USB PORT PHY reset while disconnect
> - phys : see usb-hcd.txt in the current directory
This should be implied by the HCI or phy compatible string (depending
on who exactly needs the quirky behavior).
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property
@ 2019-02-26 4:57 Srinath Mannam
0 siblings, 0 replies; 5+ messages in thread
From: Srinath Mannam @ 2019-02-26 4:57 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Mathias Nyman, Mark Rutland, linux-usb,
devicetree, Linux Kernel Mailing List
Hi Rob,
Thanks for the review, Please see my comments below in line.
Regards,
Srinath.
On Tue, Feb 26, 2019 at 3:08 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote:
> > Add usb-phy-port-reset optional property to set quirk in xhci platform
> > driver which forces USB port PHY reset on port disconnect event.
> >
> > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> > Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> > ---
> > Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > index fea8b15..ecbdb15 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -40,6 +40,7 @@ Optional properties:
> > - usb3-lpm-capable: determines if platform is USB3 LPM capable
> > - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> > - imod-interval-ns: default interrupt moderation interval is 5000ns
> > + - usb-phy-port-reset: set this to do USB PORT PHY reset while disconnect
> > - phys : see usb-hcd.txt in the current directory
>
> This should be implied by the HCI or phy compatible string (depending
> on who exactly needs the quirky behavior).
Stingray USB HS PHY connected to xHCI port has an issue, if full speed
devices connected to this port then
after all High Speed devices connected to this port are detected at
full speed instead of high speed.
So that we need to do PHY (which is connected to port) reset on xHCI
port disconnect event.
That is the reason we required to add quirk in xHCI.
>
> Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property
@ 2019-02-26 18:02 Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-02-26 18:02 UTC (permalink / raw)
To: Srinath Mannam
Cc: Greg Kroah-Hartman, Mathias Nyman, Mark Rutland, Linux USB List,
devicetree, Linux Kernel Mailing List
On Mon, Feb 25, 2019 at 10:57 PM Srinath Mannam
<srinath.mannam@broadcom.com> wrote:
>
> Hi Rob,
> Thanks for the review, Please see my comments below in line.
>
> Regards,
> Srinath.
> On Tue, Feb 26, 2019 at 3:08 AM Rob Herring <robh@kernel.org> wrote:
> >
> > On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote:
> > > Add usb-phy-port-reset optional property to set quirk in xhci platform
> > > driver which forces USB port PHY reset on port disconnect event.
> > >
> > > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> > > Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> > > ---
> > > Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > index fea8b15..ecbdb15 100644
> > > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > @@ -40,6 +40,7 @@ Optional properties:
> > > - usb3-lpm-capable: determines if platform is USB3 LPM capable
> > > - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> > > - imod-interval-ns: default interrupt moderation interval is 5000ns
> > > + - usb-phy-port-reset: set this to do USB PORT PHY reset while disconnect
> > > - phys : see usb-hcd.txt in the current directory
> >
> > This should be implied by the HCI or phy compatible string (depending
> > on who exactly needs the quirky behavior).
> Stingray USB HS PHY connected to xHCI port has an issue, if full speed
> devices connected to this port then
> after all High Speed devices connected to this port are detected at
> full speed instead of high speed.
> So that we need to do PHY (which is connected to port) reset on xHCI
> port disconnect event.
> That is the reason we required to add quirk in xHCI.
So, by looking at the xhci host and phy compatible strings (or maybe
just the phy) you can determine whether you need to reset the port or
not. All the information you need is in DT already.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property
@ 2019-02-27 17:08 Srinath Mannam
0 siblings, 0 replies; 5+ messages in thread
From: Srinath Mannam @ 2019-02-27 17:08 UTC (permalink / raw)
To: Rob Herring
Cc: Greg Kroah-Hartman, Mathias Nyman, Mark Rutland, Linux USB List,
devicetree, Linux Kernel Mailing List
Hi Rob,
Thanks for the information. Please find my comments below.
Regards,
Srinath.
On Tue, Feb 26, 2019 at 11:33 PM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Feb 25, 2019 at 10:57 PM Srinath Mannam
> <srinath.mannam@broadcom.com> wrote:
> >
> > Hi Rob,
> > Thanks for the review, Please see my comments below in line.
> >
> > Regards,
> > Srinath.
> > On Tue, Feb 26, 2019 at 3:08 AM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Tue, Feb 05, 2019 at 11:48:53AM +0530, Srinath Mannam wrote:
> > > > Add usb-phy-port-reset optional property to set quirk in xhci platform
> > > > driver which forces USB port PHY reset on port disconnect event.
> > > >
> > > > Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> > > > Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > > index fea8b15..ecbdb15 100644
> > > > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > > @@ -40,6 +40,7 @@ Optional properties:
> > > > - usb3-lpm-capable: determines if platform is USB3 LPM capable
> > > > - quirk-broken-port-ped: set if the controller has broken port disable mechanism
> > > > - imod-interval-ns: default interrupt moderation interval is 5000ns
> > > > + - usb-phy-port-reset: set this to do USB PORT PHY reset while disconnect
> > > > - phys : see usb-hcd.txt in the current directory
> > >
> > > This should be implied by the HCI or phy compatible string (depending
> > > on who exactly needs the quirky behavior).
> > Stingray USB HS PHY connected to xHCI port has an issue, if full speed
> > devices connected to this port then
> > after all High Speed devices connected to this port are detected at
> > full speed instead of high speed.
> > So that we need to do PHY (which is connected to port) reset on xHCI
> > port disconnect event.
> > That is the reason we required to add quirk in xHCI.
>
> So, by looking at the xhci host and phy compatible strings (or maybe
> just the phy) you can determine whether you need to reset the port or
> not. All the information you need is in DT already.
xHCI controller in our SOC has three ports each port has one
PHY(SS/HS) connected to it.
HS PHY has to reset on its corresponding port disconnect event. port
disconnect event is
captured in xHCI host framework so, quirk has to be registered in xHCI
framework only.
But we are using "generic-xhci" generic compatible string for our xHCI
controller.
As per your advice, we will add new compatible string in xhci-plat.c
driver for our xHCI controller
and will add quirk part of that.
Thank you.
>
> Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-27 17:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-25 21:38 [1/2] dt-bindings: usb-xhci: Add usb-phy-port-reset property Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-02-27 17:08 Srinath Mannam
2019-02-26 18:02 Rob Herring
2019-02-26 4:57 Srinath Mannam
2019-02-05 6:18 Srinath Mannam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).