From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: usb: typec: altmodes/displayport: Fall back to multi-func pins
Date: Wed, 27 Feb 2019 10:50:06 +0200 [thread overview]
Message-ID: <20190227085006.GA27730@kuha.fi.intel.com> (raw)
On Mon, Feb 25, 2019 at 07:50:32PM +0100, Hans de Goede wrote:
> Hi Heikki,
>
> On 25-02-19 16:49, Heikki Krogerus wrote:
> > On Mon, Feb 25, 2019 at 01:56:37PM +0100, Hans de Goede wrote:
> > > If our port-partner supports both DP-only operation (pin-assignment C)
> > > and multi-func operation (pin-assignment D) and we only support
> > > pin-assignment D and the port-partner prefers DP-only mode, then
> > > before this commit we would and up masking out pin-assignment D from
> > > the available pin-assignments and fail to pick a pin-assignment.
> > >
> > > Instead only mask out the multi-func pin-assignments if we support
> > > dp-only pin-assignments, so that we correctly fall-back to a multi-func
> > > pin-assignment in this case (by picking pin-assignment D).
> > >
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Should this be handled as a fix?
>
> AFAIK they are no users if this yet, until we've agreement
> on the DT bindings and code merged for adding alt-modes
> to an usb-connector node, nothing will be using this code,
> so I see little use in adding a Cc: stable or some such.
True.
thanks,
next reply other threads:[~2019-02-27 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 8:50 Heikki Krogerus [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-15 14:37 usb: typec: altmodes/displayport: Fall back to multi-func pins Heikki Krogerus
2019-02-25 18:50 Hans de Goede
2019-02-25 15:49 Heikki Krogerus
2019-02-25 12:56 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227085006.GA27730@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).