From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: VizXu <xujiweigo@163.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Add code to support USBIP Project for Windows
Date: Mon, 18 Mar 2019 18:42:47 +0100 [thread overview]
Message-ID: <20190318174247.GA22350@kroah.com> (raw)
On Mon, Mar 18, 2019 at 09:37:28AM -0700, VizXu wrote:
> Signed-off-by: VizXu <xujiweigo@163.com>
> ---
I can not take patches without any changelog text, sorry.
Please fix up and resend so we have an idea of what this patch is for
and why it is needed.
> drivers/usb/usbip/stub_dev.c | 4 ++++
> drivers/usb/usbip/stub_rx.c | 37 +++++++++++++++++++++++++++++++++++++
> drivers/usb/usbip/usbip_common.h | 16 ++++++++++++++++
> 3 files changed, 57 insertions(+)
>
> diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c
> index c0d6ff1..be95c72 100644
> --- a/drivers/usb/usbip/stub_dev.c
> +++ b/drivers/usb/usbip/stub_dev.c
> @@ -270,6 +270,10 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev)
> sdev->ud.tcp_socket = NULL;
> sdev->ud.sockfd = -1;
>
> +#ifdef SUPPORT_WIN
> + sdev->ud.is_configured = false;
> +#endif
#ifdef should never be in a .c file if at all possible. Please rework
this to use the proper style of doing this type of thing in a .h file.
thanks,
greg k-h
next reply other threads:[~2019-03-18 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:42 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-18 16:52 Add code to support USBIP Project for Windows Randy Dunlap
2019-03-18 16:37 VizXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318174247.GA22350@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=xujiweigo@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).