linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Måns Rullgård" <mans@mansr.com>
Cc: "Johan Hovold" <johan@kernel.org>, "Bjørn Mork" <bjorn@mork.no>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: USB: serial: option: set driver_info for SIM5218 and compatibles
Date: Tue, 19 Mar 2019 12:08:19 +0100	[thread overview]
Message-ID: <20190319110819.GB3178@localhost> (raw)

On Tue, Mar 19, 2019 at 10:54:00AM +0000, Måns Rullgård wrote:
> Johan Hovold <johan@kernel.org> writes:

> >> Regardless, setting the NCTRL flag should be harmless.
> >
> > Well, there are devices that depend on getting these requests, at least
> > for the QMI interface. But we can always revert if anyone complains.
> 
> The QMI interface doesn't even pretend to be a uart.  The other ones do,
> but there isn't actually any real uart behind them.  For instance, it
> doesn't matter what baud rate one sets.

Sure, but some devices still require "DTR" to be set for the QMI
interface, so there not being any real uart is no guarantee that there
is no firmware that expects these calls.

Johan

             reply	other threads:[~2019-03-19 11:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 11:08 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-03-19 17:15 USB: serial: option: set driver_info for SIM5218 and compatibles Bjørn Mork
2019-03-19 16:26 Måns Rullgård
2019-03-19 14:59 Bjørn Mork
2019-03-19 14:35 Måns Rullgård
2019-03-19 14:30 Dan Williams
2019-03-19 12:43 Johan Hovold
2019-03-19 12:27 Johan Hovold
2019-03-19 12:25 Måns Rullgård
2019-03-19 10:54 Måns Rullgård
2019-03-19 10:28 Johan Hovold
2019-03-18 14:32 Måns Rullgård
2019-02-27 14:32 Måns Rullgård
2019-02-27 13:13 Johan Hovold
2019-02-27 11:57 Måns Rullgård
2019-02-27  8:33 Johan Hovold
2019-02-26 17:07 Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319110819.GB3178@localhost \
    --to=johan@kernel.org \
    --cc=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mans@mansr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).