From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: sierra: fix a missing check of device_create_file From: kbuild test robot Message-Id: <201903251039.4BQ4btxI%lkp@intel.com> Date: Mon, 25 Mar 2019 10:47:15 +0800 To: Kangjie Lu Cc: kbuild-all@01.org, pakki001@umn.edu, Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org List-ID: SGkgS2FuZ2ppZSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoISBQZXJoYXBzIHNvbWV0aGluZyB0 byBpbXByb3ZlOgoKW2F1dG8gYnVpbGQgdGVzdCBXQVJOSU5HIG9uIHVzYi91c2ItdGVzdGluZ10K W2Fsc28gYnVpbGQgdGVzdCBXQVJOSU5HIG9uIHY1LjEtcmMyIG5leHQtMjAxOTAzMjJdCltpZiB5 b3VyIHBhdGNoIGlzIGFwcGxpZWQgdG8gdGhlIHdyb25nIGdpdCB0cmVlLCBwbGVhc2UgZHJvcCB1 cyBhIG5vdGUgdG8gaGVscCBpbXByb3ZlIHRoZSBzeXN0ZW1dCgp1cmw6ICAgIGh0dHBzOi8vZ2l0 aHViLmNvbS8wZGF5LWNpL2xpbnV4L2NvbW1pdHMvS2FuZ2ppZS1MdS91c2Itc2llcnJhLWZpeC1h LW1pc3NpbmctY2hlY2stb2YtZGV2aWNlX2NyZWF0ZV9maWxlLzIwMTkwMzI1LTEwMTMyOApiYXNl OiAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2dyZWdr aC91c2IuZ2l0IHVzYi10ZXN0aW5nCmNvbmZpZzogeDg2XzY0LXJhbmRjb25maWcteDAwOS0yMDE5 MTIgKGF0dGFjaGVkIGFzIC5jb25maWcpCmNvbXBpbGVyOiBnY2MtNyAoRGViaWFuIDcuMy4wLTEp IDcuMy4wCnJlcHJvZHVjZToKICAgICAgICAjIHNhdmUgdGhlIGF0dGFjaGVkIC5jb25maWcgdG8g bGludXggYnVpbGQgdHJlZQogICAgICAgIG1ha2UgQVJDSD14ODZfNjQgCgpOb3RlOiBpdCBtYXkg d2VsbCBiZSBhIEZBTFNFIHdhcm5pbmcuIEZXSVcgeW91IGFyZSBhdCBsZWFzdCBhd2FyZSBvZiBp dCBub3cuCmh0dHA6Ly9nY2MuZ251Lm9yZy93aWtpL0JldHRlcl9VbmluaXRpYWxpemVkX1dhcm5p bmdzCgpBbGwgd2FybmluZ3MgKG5ldyBvbmVzIHByZWZpeGVkIGJ5ID4+KToKCiAgIGRyaXZlcnMv dXNiL3N0b3JhZ2Uvc2llcnJhX21zLmM6IEluIGZ1bmN0aW9uICdzaWVycmFfbXNfaW5pdCc6Cj4+ IGRyaXZlcnMvdXNiL3N0b3JhZ2Uvc2llcnJhX21zLmM6MTk5OjM6IHdhcm5pbmc6ICdzd29jSW5m bycgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBpbiB0aGlzIGZ1bmN0aW9uIFstV21heWJlLXVu aW5pdGlhbGl6ZWRdCiAgICAgIGtmcmVlKHN3b2NJbmZvKTsKICAgICAgXn5+fn5+fn5+fn5+fn5+ Cgp2aW0gKy9zd29jSW5mbyArMTk5IGRyaXZlcnMvdXNiL3N0b3JhZ2Uvc2llcnJhX21zLmMKCiAg IDEyNgkKICAgMTI3CWludCBzaWVycmFfbXNfaW5pdChzdHJ1Y3QgdXNfZGF0YSAqdXMpCiAgIDEy OAl7CiAgIDEyOQkJaW50IHJlc3VsdCwgcmV0cmllczsKICAgMTMwCQlzdHJ1Y3Qgc3dvY19pbmZv ICpzd29jSW5mbzsKICAgMTMxCQlzdHJ1Y3QgdXNiX2RldmljZSAqdWRldjsKICAgMTMyCQlzdHJ1 Y3QgU2NzaV9Ib3N0ICpzaDsKICAgMTMzCQogICAxMzQJCXJldHJpZXMgPSAzOwogICAxMzUJCXJl c3VsdCA9IDA7CiAgIDEzNgkJdWRldiA9IHVzLT5wdXNiX2RldjsKICAgMTM3CQogICAxMzgJCXNo ID0gdXNfdG9faG9zdCh1cyk7CiAgIDEzOQkJc2NzaV9nZXRfaG9zdF9kZXYoc2gpOwogICAxNDAJ CiAgIDE0MQkJLyogRm9yY2UgTW9kZW0gbW9kZSAqLwogICAxNDIJCWlmIChzd2lfdHJ1X2luc3Rh bGwgPT0gVFJVX0ZPUkNFX01PREVNKSB7CiAgIDE0MwkJCXVzYl9zdG9yX2RiZyh1cywgIlNXSU1T OiBGb3JjaW5nIE1vZGVtIE1vZGVcbiIpOwogICAxNDQJCQlyZXN1bHQgPSBzaWVycmFfc2V0X21z X21vZGUodWRldiwgU1dJTVNfU0VUX01PREVfTW9kZW0pOwogICAxNDUJCQlpZiAocmVzdWx0IDwg MCkKICAgMTQ2CQkJCXVzYl9zdG9yX2RiZyh1cywgIlNXSU1TOiBGYWlsZWQgdG8gc3dpdGNoIHRv IG1vZGVtIG1vZGVcbiIpOwogICAxNDcJCQlyZXR1cm4gLUVJTzsKICAgMTQ4CQl9CiAgIDE0OQkJ LyogRm9yY2UgTWFzcyBTdG9yYWdlIG1vZGUgKGtlZXAgQ0QtUm9tKSAqLwogICAxNTAJCWVsc2Ug aWYgKHN3aV90cnVfaW5zdGFsbCA9PSBUUlVfRk9SQ0VfTVMpIHsKICAgMTUxCQkJdXNiX3N0b3Jf ZGJnKHVzLCAiU1dJTVM6IEZvcmNpbmcgTWFzcyBTdG9yYWdlIE1vZGVcbiIpOwogICAxNTIJCQln b3RvIGNvbXBsZXRlOwogICAxNTMJCX0KICAgMTU0CQkvKiBOb3JtYWwgVFJVLUluc3RhbGwgTG9n aWMgKi8KICAgMTU1CQllbHNlIHsKICAgMTU2CQkJdXNiX3N0b3JfZGJnKHVzLCAiU1dJTVM6IE5v cm1hbCBTV29DIExvZ2ljXG4iKTsKICAgMTU3CQogICAxNTgJCQlzd29jSW5mbyA9IGttYWxsb2Mo c2l6ZW9mKHN0cnVjdCBzd29jX2luZm8pLAogICAxNTkJCQkJCUdGUF9LRVJORUwpOwogICAxNjAJ CQlpZiAoIXN3b2NJbmZvKQogICAxNjEJCQkJcmV0dXJuIC1FTk9NRU07CiAgIDE2MgkKICAgMTYz CQkJcmV0cmllcyA9IDM7CiAgIDE2NAkJCWRvIHsKICAgMTY1CQkJCXJldHJpZXMtLTsKICAgMTY2 CQkJCXJlc3VsdCA9IHNpZXJyYV9nZXRfc3dvY19pbmZvKHVkZXYsIHN3b2NJbmZvKTsKICAgMTY3 CQkJCWlmIChyZXN1bHQgPCAwKSB7CiAgIDE2OAkJCQkJdXNiX3N0b3JfZGJnKHVzLCAiU1dJTVM6 IEZhaWxlZCBTV29DIHF1ZXJ5XG4iKTsKICAgMTY5CQkJCQlzY2hlZHVsZV90aW1lb3V0X3VuaW50 ZXJydXB0aWJsZSgyKkhaKTsKICAgMTcwCQkJCX0KICAgMTcxCQkJfSB3aGlsZSAocmV0cmllcyAm JiByZXN1bHQgPCAwKTsKICAgMTcyCQogICAxNzMJCQlpZiAocmVzdWx0IDwgMCkgewogICAxNzQJ CQkJdXNiX3N0b3JfZGJnKHVzLCAiU1dJTVM6IENvbXBsZXRlbHkgZmFpbGVkIFNXb0MgcXVlcnlc biIpOwogICAxNzUJCQkJa2ZyZWUoc3dvY0luZm8pOwogICAxNzYJCQkJcmV0dXJuIC1FSU87CiAg IDE3NwkJCX0KICAgMTc4CQogICAxNzkJCQlkZWJ1Z19zd29jKCZ1cy0+cHVzYl9kZXYtPmRldiwg c3dvY0luZm8pOwogICAxODAJCiAgIDE4MQkJCS8qCiAgIDE4MgkJCSAqIElmIHRoZXJlIGlzIG5v dCBMaW51eCBzb2Z0d2FyZSBvbiB0aGUgVFJVLUluc3RhbGwgZGV2aWNlCiAgIDE4MwkJCSAqIHRo ZW4gc3dpdGNoIHRvIG1vZGVtIG1vZGUKICAgMTg0CQkJICovCiAgIDE4NQkJCWlmICghY29udGFp bnNGdWxsTGludXhQYWNrYWdlKHN3b2NJbmZvKSkgewogICAxODYJCQkJdXNiX3N0b3JfZGJnKHVz LCAiU1dJTVM6IFN3aXRjaGluZyB0byBNb2RlbSBNb2RlXG4iKTsKICAgMTg3CQkJCXJlc3VsdCA9 IHNpZXJyYV9zZXRfbXNfbW9kZSh1ZGV2LAogICAxODgJCQkJCVNXSU1TX1NFVF9NT0RFX01vZGVt KTsKICAgMTg5CQkJCWlmIChyZXN1bHQgPCAwKQogICAxOTAJCQkJCXVzYl9zdG9yX2RiZyh1cywg IlNXSU1TOiBGYWlsZWQgdG8gc3dpdGNoIG1vZGVtXG4iKTsKICAgMTkxCQkJCWtmcmVlKHN3b2NJ bmZvKTsKICAgMTkyCQkJCXJldHVybiAtRUlPOwogICAxOTMJCQl9CiAgIDE5NAkJCWtmcmVlKHN3 b2NJbmZvKTsKICAgMTk1CQl9CiAgIDE5Ngljb21wbGV0ZToKICAgMTk3CQlyZXN1bHQgPSBkZXZp Y2VfY3JlYXRlX2ZpbGUoJnVzLT5wdXNiX2ludGYtPmRldiwgJmRldl9hdHRyX3RydWluc3QpOwog ICAxOTgJCWlmIChyZXN1bHQpIHsKID4gMTk5CQkJa2ZyZWUoc3dvY0luZm8pOwogICAyMDAJCQly ZXR1cm4gcmVzdWx0OwogICAyMDEJCX0KICAgMjAyCQogICAyMDMJCXJldHVybiAwOwogICAyMDQJ fQogICAyMDUKLS0tCjAtREFZIGtlcm5lbCB0ZXN0IGluZnJhc3RydWN0dXJlICAgICAgICAgICAg ICAgIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCmh0dHBzOi8vbGlzdHMuMDEub3JnL3Bp cGVybWFpbC9rYnVpbGQtYWxsICAgICAgICAgICAgICAgICAgIEludGVsIENvcnBvcmF0aW9uCg==