From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Josh Boyer <jwboyer@fedoraproject.org>,
Ralf Spenneberg <ralf@spenneberg.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [BACKPORT,4.4.y,04/25] USB: iowarrior: fix oops with malicious USB descriptors
Date: Tue, 26 Mar 2019 10:13:19 +0900 [thread overview]
Message-ID: <20190326011319.GC29420@kroah.com> (raw)
On Fri, Mar 22, 2019 at 04:43:55PM +0100, Arnd Bergmann wrote:
> From: Josh Boyer <jwboyer@fedoraproject.org>
>
> The iowarrior driver expects at least one valid endpoint. If given
> malicious descriptors that specify 0 for the number of endpoints,
> it will crash in the probe function. Ensure there is at least
> one endpoint on the interface before using it.
>
> The full report of this issue can be found here:
> http://seclists.org/bugtraq/2016/Mar/87
>
> Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 4ec0ef3a82125efc36173062a50624550a900ae0)
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/misc/iowarrior.c | 6 ++++++
> 1 file changed, 6 insertions(+)
This commit has been in the tree for a long time. It was in the 4.4.7
release, back in April 2016. And then it was reverted in commit
b7321e81fc36 ("USB: iowarrior: fix NULL-deref at probe") as it broke
systems. So why add it back, the correct functionality should be there
today, right?
thanks,
greg k-h
next reply other threads:[~2019-03-26 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 1:13 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-26 9:47 [BACKPORT,4.4.y,04/25] USB: iowarrior: fix oops with malicious USB descriptors 翟京 (Orson Zhai)
2019-03-26 9:35 Baolin Wang
2019-03-26 8:20 Arnd Bergmann
2019-03-22 15:43 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326011319.GC29420@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=gustavo@embeddedor.com \
--cc=jwboyer@fedoraproject.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ralf@spenneberg.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).