From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: sierra: fix a missing check of device_create_file From: Dan Carpenter Message-Id: <20190326081831.GF32613@kadam> Date: Tue, 26 Mar 2019 11:18:31 +0300 To: kbuild@01.org, Kangjie Lu Cc: kbuild-all@01.org, pakki001@umn.edu, Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org List-ID: SGkgS2FuZ2ppZSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoISBQZXJoYXBzIHNvbWV0aGluZyB0 byBpbXByb3ZlOgoKdXJsOiAgICBodHRwczovL2dpdGh1Yi5jb20vMGRheS1jaS9saW51eC9jb21t aXRzL0thbmdqaWUtTHUvdXNiLXNpZXJyYS1maXgtYS1taXNzaW5nLWNoZWNrLW9mLWRldmljZV9j cmVhdGVfZmlsZS8yMDE5MDMyNS0xMDEzMjgKYmFzZTogICBodHRwczovL2dpdC5rZXJuZWwub3Jn L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9ncmVna2gvdXNiLmdpdCB1c2ItdGVzdGluZwoKc21h dGNoIHdhcm5pbmdzOgpkcml2ZXJzL3VzYi9zdG9yYWdlL3NpZXJyYV9tcy5jOjE5OSBzaWVycmFf bXNfaW5pdCgpIGVycm9yOiBkb3VibGUgZnJlZSBvZiAnc3dvY0luZm8nCgojIGh0dHBzOi8vZ2l0 aHViLmNvbS8wZGF5LWNpL2xpbnV4L2NvbW1pdC8wNGQ2NmYzZDA3MmMzZDE0MzA4YWViZWNkYmMw ZjI5ODNjZTQ0M2QyCmdpdCByZW1vdGUgYWRkIGxpbnV4LXJldmlldyBodHRwczovL2dpdGh1Yi5j b20vMGRheS1jaS9saW51eApnaXQgcmVtb3RlIHVwZGF0ZSBsaW51eC1yZXZpZXcKZ2l0IGNoZWNr b3V0IDA0ZDY2ZjNkMDcyYzNkMTQzMDhhZWJlY2RiYzBmMjk4M2NlNDQzZDIKdmltICsvc3dvY0lu Zm8gKzE5OSBkcml2ZXJzL3VzYi9zdG9yYWdlL3NpZXJyYV9tcy5jCgozMmZlNWUzOTMgS2V2aW4g TGxveWQgIDIwMDgtMDctMTAgIDEyNiAgCjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0x MCAgMTI3ICBpbnQgc2llcnJhX21zX2luaXQoc3RydWN0IHVzX2RhdGEgKnVzKQozMmZlNWUzOTMg S2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDEyOCAgewozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIw MDgtMDctMTAgIDEyOSAgCWludCByZXN1bHQsIHJldHJpZXM7CjMyZmU1ZTM5MyBLZXZpbiBMbG95 ZCAgMjAwOC0wNy0xMCAgMTMwICAJc3RydWN0IHN3b2NfaW5mbyAqc3dvY0luZm87CjMyZmU1ZTM5 MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTMxICAJc3RydWN0IHVzYl9kZXZpY2UgKnVkZXY7 CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTMyICAJc3RydWN0IFNjc2lfSG9z dCAqc2g7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTMzICAKMzJmZTVlMzkz IEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxMzQgIAlyZXRyaWVzID0gMzsKMzJmZTVlMzkzIEtl dmluIExsb3lkICAyMDA4LTA3LTEwICAxMzUgIAlyZXN1bHQgPSAwOwozMmZlNWUzOTMgS2V2aW4g TGxveWQgIDIwMDgtMDctMTAgIDEzNiAgCXVkZXYgPSB1cy0+cHVzYl9kZXY7CjMyZmU1ZTM5MyBL ZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTM3ICAKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4 LTA3LTEwICAxMzggIAlzaCA9IHVzX3RvX2hvc3QodXMpOwowMjIwYTNmMDEgQWxhbiBDb3ggICAg IDIwMTItMDktMTkgIDEzOSAgCXNjc2lfZ2V0X2hvc3RfZGV2KHNoKTsKMzJmZTVlMzkzIEtldmlu IExsb3lkICAyMDA4LTA3LTEwICAxNDAgIAozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDct MTAgIDE0MSAgCS8qIEZvcmNlIE1vZGVtIG1vZGUgKi8KMzJmZTVlMzkzIEtldmluIExsb3lkICAy MDA4LTA3LTEwICAxNDIgIAlpZiAoc3dpX3RydV9pbnN0YWxsID09IFRSVV9GT1JDRV9NT0RFTSkg ewoxOTE2NDhkMDMgSm9lIFBlcmNoZXMgIDIwMTMtMDQtMTkgIDE0MyAgCQl1c2Jfc3Rvcl9kYmco dXMsICJTV0lNUzogRm9yY2luZyBNb2RlbSBNb2RlXG4iKTsKMzJmZTVlMzkzIEtldmluIExsb3lk ICAyMDA4LTA3LTEwICAxNDQgIAkJcmVzdWx0ID0gc2llcnJhX3NldF9tc19tb2RlKHVkZXYsIFNX SU1TX1NFVF9NT0RFX01vZGVtKTsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAx NDUgIAkJaWYgKHJlc3VsdCA8IDApCjE5MTY0OGQwMyBKb2UgUGVyY2hlcyAgMjAxMy0wNC0xOSAg MTQ2ICAJCQl1c2Jfc3Rvcl9kYmcodXMsICJTV0lNUzogRmFpbGVkIHRvIHN3aXRjaCB0byBtb2Rl bSBtb2RlXG4iKTsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxNDcgIAkJcmV0 dXJuIC1FSU87CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTQ4ICAJfQozMmZl NWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE0OSAgCS8qIEZvcmNlIE1hc3MgU3RvcmFn ZSBtb2RlIChrZWVwIENELVJvbSkgKi8KMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEw ICAxNTAgIAllbHNlIGlmIChzd2lfdHJ1X2luc3RhbGwgPT0gVFJVX0ZPUkNFX01TKSB7CjE5MTY0 OGQwMyBKb2UgUGVyY2hlcyAgMjAxMy0wNC0xOSAgMTUxICAJCXVzYl9zdG9yX2RiZyh1cywgIlNX SU1TOiBGb3JjaW5nIE1hc3MgU3RvcmFnZSBNb2RlXG4iKTsKMzJmZTVlMzkzIEtldmluIExsb3lk ICAyMDA4LTA3LTEwICAxNTIgIAkJZ290byBjb21wbGV0ZTsKMzJmZTVlMzkzIEtldmluIExsb3lk ICAyMDA4LTA3LTEwICAxNTMgIAl9CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAg MTU0ICAJLyogTm9ybWFsIFRSVS1JbnN0YWxsIExvZ2ljICovCjMyZmU1ZTM5MyBLZXZpbiBMbG95 ZCAgMjAwOC0wNy0xMCAgMTU1ICAJZWxzZSB7CjE5MTY0OGQwMyBKb2UgUGVyY2hlcyAgMjAxMy0w NC0xOSAgMTU2ICAJCXVzYl9zdG9yX2RiZyh1cywgIlNXSU1TOiBOb3JtYWwgU1dvQyBMb2dpY1xu Iik7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTU3ICAKMzJmZTVlMzkzIEtl dmluIExsb3lkICAyMDA4LTA3LTEwICAxNTggIAkJc3dvY0luZm8gPSBrbWFsbG9jKHNpemVvZihz dHJ1Y3Qgc3dvY19pbmZvKSwKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxNTkg IAkJCQlHRlBfS0VSTkVMKTsKMTkxNjQ4ZDAzIEpvZSBQZXJjaGVzICAyMDEzLTA0LTE5ICAxNjAg IAkJaWYgKCFzd29jSW5mbykKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxNjEg IAkJCXJldHVybiAtRU5PTUVNOwozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE2 MiAgCjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTYzICAJCXJldHJpZXMgPSAz OwozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE2NCAgCQlkbyB7CjMyZmU1ZTM5 MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTY1ICAJCQlyZXRyaWVzLS07CjMyZmU1ZTM5MyBL ZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTY2ICAJCQlyZXN1bHQgPSBzaWVycmFfZ2V0X3N3b2Nf aW5mbyh1ZGV2LCBzd29jSW5mbyk7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAg MTY3ICAJCQlpZiAocmVzdWx0IDwgMCkgewoxOTE2NDhkMDMgSm9lIFBlcmNoZXMgIDIwMTMtMDQt MTkgIDE2OCAgCQkJCXVzYl9zdG9yX2RiZyh1cywgIlNXSU1TOiBGYWlsZWQgU1dvQyBxdWVyeVxu Iik7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTY5ICAJCQkJc2NoZWR1bGVf dGltZW91dF91bmludGVycnVwdGlibGUoMipIWik7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAw OC0wNy0xMCAgMTcwICAJCQl9CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTcx ICAJCX0gd2hpbGUgKHJldHJpZXMgJiYgcmVzdWx0IDwgMCk7CjMyZmU1ZTM5MyBLZXZpbiBMbG95 ZCAgMjAwOC0wNy0xMCAgMTcyICAKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAx NzMgIAkJaWYgKHJlc3VsdCA8IDApIHsKMTkxNjQ4ZDAzIEpvZSBQZXJjaGVzICAyMDEzLTA0LTE5 ICAxNzQgIAkJCXVzYl9zdG9yX2RiZyh1cywgIlNXSU1TOiBDb21wbGV0ZWx5IGZhaWxlZCBTV29D IHF1ZXJ5XG4iKTsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxNzUgIAkJCWtm cmVlKHN3b2NJbmZvKTsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxNzYgIAkJ CXJldHVybiAtRUlPOwozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE3NyAgCQl9 CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTc4ICAKMTkxNjQ4ZDAzIEpvZSBQ ZXJjaGVzICAyMDEzLTA0LTE5ICAxNzkgIAkJZGVidWdfc3dvYygmdXMtPnB1c2JfZGV2LT5kZXYs IHN3b2NJbmZvKTsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxODAgIApmMDE4 M2EzMzggRmVsaXBlIEJhbGJpIDIwMTYtMDQtMTggIDE4MSAgCQkvKgpmMDE4M2EzMzggRmVsaXBl IEJhbGJpIDIwMTYtMDQtMTggIDE4MiAgCQkgKiBJZiB0aGVyZSBpcyBub3QgTGludXggc29mdHdh cmUgb24gdGhlIFRSVS1JbnN0YWxsIGRldmljZQozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgt MDctMTAgIDE4MyAgCQkgKiB0aGVuIHN3aXRjaCB0byBtb2RlbSBtb2RlCjMyZmU1ZTM5MyBLZXZp biBMbG95ZCAgMjAwOC0wNy0xMCAgMTg0ICAJCSAqLwozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIw MDgtMDctMTAgIDE4NSAgCQlpZiAoIWNvbnRhaW5zRnVsbExpbnV4UGFja2FnZShzd29jSW5mbykp IHsKMTkxNjQ4ZDAzIEpvZSBQZXJjaGVzICAyMDEzLTA0LTE5ICAxODYgIAkJCXVzYl9zdG9yX2Ri Zyh1cywgIlNXSU1TOiBTd2l0Y2hpbmcgdG8gTW9kZW0gTW9kZVxuIik7CjMyZmU1ZTM5MyBLZXZp biBMbG95ZCAgMjAwOC0wNy0xMCAgMTg3ICAJCQlyZXN1bHQgPSBzaWVycmFfc2V0X21zX21vZGUo dWRldiwKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxODggIAkJCQlTV0lNU19T RVRfTU9ERV9Nb2RlbSk7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTg5ICAJ CQlpZiAocmVzdWx0IDwgMCkKMTkxNjQ4ZDAzIEpvZSBQZXJjaGVzICAyMDEzLTA0LTE5ICAxOTAg IAkJCQl1c2Jfc3Rvcl9kYmcodXMsICJTV0lNUzogRmFpbGVkIHRvIHN3aXRjaCBtb2RlbVxuIik7 CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTkxICAJCQlrZnJlZShzd29jSW5m byk7CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTkyICAJCQlyZXR1cm4gLUVJ TzsKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxOTMgIAkJfQozMmZlNWUzOTMg S2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE5NCAgCQlrZnJlZShzd29jSW5mbyk7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXl5eXl5eXl5e Xl5eXl5eXgoKMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAxOTUgIAl9CgpicmVh ayBzdGF0ZW1lbnQ/CgozMmZlNWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDE5NiAgY29t cGxldGU6CjMyZmU1ZTM5MyBLZXZpbiBMbG95ZCAgMjAwOC0wNy0xMCAgMTk3ICAJcmVzdWx0ID0g ZGV2aWNlX2NyZWF0ZV9maWxlKCZ1cy0+cHVzYl9pbnRmLT5kZXYsICZkZXZfYXR0cl90cnVpbnN0 KTsKMDRkNjZmM2QwIEthbmdqaWUgTHUgICAyMDE5LTAzLTI0ICAxOTggIAlpZiAocmVzdWx0KSB7 CjA0ZDY2ZjNkMCBLYW5namllIEx1ICAgMjAxOS0wMy0yNCBAMTk5ICAJCWtmcmVlKHN3b2NJbmZv KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBeXl5eXl5eXl5eXl5eXl4KRG91YmxlIGZyZWUuCgowNGQ2NmYzZDAgS2FuZ2ppZSBMdSAgIDIw MTktMDMtMjQgIDIwMCAgCQlyZXR1cm4gcmVzdWx0OwowNGQ2NmYzZDAgS2FuZ2ppZSBMdSAgIDIw MTktMDMtMjQgIDIwMSAgCX0KMzJmZTVlMzkzIEtldmluIExsb3lkICAyMDA4LTA3LTEwICAyMDIg IApiZTQ3NWQ5MDIgQWxhbiBTdGVybiAgIDIwMDktMDUtMjEgIDIwMyAgCXJldHVybiAwOwozMmZl NWUzOTMgS2V2aW4gTGxveWQgIDIwMDgtMDctMTAgIDIwNCAgfQozMmZlNWUzOTMgS2V2aW4gTGxv eWQgIDIwMDgtMDctMTAgIDIwNQotLS0KMC1EQVkga2VybmVsIHRlc3QgaW5mcmFzdHJ1Y3R1cmUg ICAgICAgICAgICAgICAgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKaHR0cHM6Ly9saXN0 cy4wMS5vcmcvcGlwZXJtYWlsL2tidWlsZC1hbGwgICAgICAgICAgICAgICAgICAgSW50ZWwgQ29y cG9yYXRpb24K