From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: trivial@kernel.org, Sarah Sharp <sarah.a.sharp@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: USB/xHCI: Remove returned value 'status' since never used
Date: Thu, 28 Mar 2019 00:02:04 +0900 [thread overview]
Message-ID: <20190327150204.GA22617@kroah.com> (raw)
On Tue, Mar 26, 2019 at 09:15:57PM +0100, Mathieu Malaterre wrote:
> The returned value in status has never been used since
> commit 4296c70a5ec3 ("USB/xHCI: Enable USB 3.0 hub remote wakeup.")
> So remove 'status' completely.
>
> Remove warning (W=1):
>
> drivers/usb/core/hub.c:3671:8: warning: variable 'status' set but not used [-Wunused-but-set-variable]
>
> Cc: Sarah Sharp <sarah.a.sharp@intel.com>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/usb/core/hub.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Why do you have xhci in your subject line? Shouldn't it be "USB: hub:"?
Please fix up, thanks.
greg k-h
next reply other threads:[~2019-03-27 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 15:02 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-27 11:21 USB/xHCI: Remove returned value 'status' since never used Mukesh Ojha
2019-03-26 20:15 Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327150204.GA22617@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=malat@debian.org \
--cc=sarah.a.sharp@intel.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).