* [2/9] dt-bindings: usb: renesas_usb3: add extcon support
@ 2019-03-06 9:07 Biju Das
0 siblings, 0 replies; 3+ messages in thread
From: Biju Das @ 2019-03-06 9:07 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Greg Kroah-Hartman, Heikki Krogerus, Felipe Balbi,
linux-usb, devicetree, Simon Horman, Yoshihiro Shimoda,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro,
linux-renesas-soc
Add support for renesas_usb3 to receive connect and disconnect notification
using extcon framework.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
index d366555..ae35674 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
@@ -21,6 +21,8 @@ Required properties:
Optional properties:
- phys: phandle + phy specifier pair
- phy-names: must be "usb"
+ - extcon: phandle for the extcon device renesas usb3 uses to detect
+ connect/disconnect events.
Example of R-Car H3 ES1.x:
usb3_peri0: usb@ee020000 {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [2/9] dt-bindings: usb: renesas_usb3: add extcon support
@ 2019-03-27 23:28 Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-03-27 23:28 UTC (permalink / raw)
To: Biju Das
Cc: Mark Rutland, Greg Kroah-Hartman, Heikki Krogerus, Felipe Balbi,
linux-usb, devicetree, Simon Horman, Yoshihiro Shimoda,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro,
linux-renesas-soc
On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote:
> Add support for renesas_usb3 to receive connect and disconnect notification
> using extcon framework.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> index d366555..ae35674 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> @@ -21,6 +21,8 @@ Required properties:
> Optional properties:
> - phys: phandle + phy specifier pair
> - phy-names: must be "usb"
> + - extcon: phandle for the extcon device renesas usb3 uses to detect
> + connect/disconnect events.
Please don't use extcon and use usb-connector binding instead.
>
> Example of R-Car H3 ES1.x:
> usb3_peri0: usb@ee020000 {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2/9] dt-bindings: usb: renesas_usb3: add extcon support
@ 2019-03-28 13:04 Biju Das
0 siblings, 0 replies; 3+ messages in thread
From: Biju Das @ 2019-03-28 13:04 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Greg Kroah-Hartman, Heikki Krogerus, Felipe Balbi,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Simon Horman, Yoshihiro Shimoda, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro,
linux-renesas-soc@vger.kernel.org
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support
>
> On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote:
> > Add support for renesas_usb3 to receive connect and disconnect
> > notification using extcon framework.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > index d366555..ae35674 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt
> > @@ -21,6 +21,8 @@ Required properties:
> > Optional properties:
> > - phys: phandle + phy specifier pair
> > - phy-names: must be "usb"
> > + - extcon: phandle for the extcon device renesas usb3 uses to detect
> > + connect/disconnect events.
>
> Please don't use extcon and use usb-connector binding instead.
I have switched to usb role switch framework instead of extcon and sent V2 based on the below feedback.
https://patchwork.kernel.org/patch/10840659/
On V2, I have sent a patch series which uses " usb-connector " binding [1] and "usb-role-switch" property[2]
[1] https://patchwork.kernel.org/patch/10852495/
[2] https://patchwork.kernel.org/patch/10852497/
Support for "usb-role-switch" compatible can be found in the below patch set
https://patchwork.kernel.org/project/linux-usb/list/?series=97707
Please can you comment, is this approach is acceptable or not?
Regards,
Biju
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-28 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-27 23:28 [2/9] dt-bindings: usb: renesas_usb3: add extcon support Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-03-28 13:04 Biju Das
2019-03-06 9:07 Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).