From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: musb: Silence error about blacklisting hubs if !CONFIG_USB
Date: Mon, 1 Apr 2019 13:34:42 -0500 [thread overview]
Message-ID: <20190401183442.GM25852@uda0271908> (raw)
On Mon, Apr 01, 2019 at 07:51:59PM +0200, Paul Cercueil wrote:
>
>
> Le lun. 1 avril 2019 à 17:43, Bin Liu <b-liu@ti.com> a écrit :
> >On Tue, Mar 19, 2019 at 02:51:46PM +0100, Paul Cercueil wrote:
> >> Some drivers, like jz4740-musb, don't depend on CONFIG_USB.
> >
> >CONFIG_USB_OTG_BLACKLIST_HUB is about hub, so should it depend on
> >CONFIG_USB instead in drivers/usb/core/Kconfig?
>
> It's already the case, indirectly - it depends on CONFIG_USB_OTG,
> which only exists if CONFIG_USB is set.
Never mind, my bad, I misunderstood the logic.
> >>
> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >> ---
> >> drivers/usb/musb/musb_core.c | 9 +++++----
> >> 1 file changed, 5 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/musb/musb_core.c
> >>b/drivers/usb/musb/musb_core.c
> >> index b7d56272f9d1..9f5a4819a744 100644
> >> --- a/drivers/usb/musb/musb_core.c
> >> +++ b/drivers/usb/musb/musb_core.c
> >> @@ -1497,10 +1497,11 @@ static int musb_core_init(u16
> >>musb_type, struct musb *musb)
> >> } else {
> >> musb->is_multipoint = 0;
> >> type = "";
> >> -#ifndef CONFIG_USB_OTG_BLACKLIST_HUB
> >> - pr_err("%s: kernel must blacklist external hubs\n",
> >> - musb_driver_name);
> >> -#endif
> >> + if (IS_ENABLED(CONFIG_USB) &&
> >> + !IS_ENABLED(CONFIG_USB_OTG_BLACKLIST_HUB)) {
> >> + pr_err("%s: kernel must blacklist external hubs\n",
> >> + musb_driver_name);
> >> + }
> >> }
> >>
> >> /* log release info */
The patch is applied.
Thanks,
-Bin.
next reply other threads:[~2019-04-01 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 18:34 Bin Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-01 17:51 usb: musb: Silence error about blacklisting hubs if !CONFIG_USB Paul Cercueil
2019-04-01 15:43 Bin Liu
2019-03-19 13:51 Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401183442.GM25852@uda0271908 \
--to=b-liu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).