linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org, Florian Zumbiehl <florz@florz.de>,
	Charles Yeh <charlesyeh522@gmail.com>
Subject: [2/2] USB: serial: pl2303: fix tranceiver suspend mode
Date: Wed, 3 Apr 2019 09:48:37 +0200	[thread overview]
Message-ID: <20190403074837.GE6734@localhost> (raw)

On Tue, Apr 02, 2019 at 02:04:09PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 02, 2019 at 10:22:06AM +0200, Johan Hovold wrote:
> > On Tue, Apr 02, 2019 at 10:19:31AM +0200, Johan Hovold wrote:
> > > Add helper function to update register bits instead of overwriting the
> > > entire control register when updating the flow-control settings.
> > > 
> > > This specifically avoids having the tranceiver suspend mode (bit 0)
> > > depend on the flow control setting.
> > > 
> > > The tranceiver is currently configured at probe to be disabled during
> > > suspend, but this was overridden when disabling flow control or enabling
> > > xon/xoff.
> > > 
> > > Fixes: 715f9527c1c1 ("USB: flow control fix for pl2303")
> > > Fixes: 7041d9c3f01b ("USB: serial: pl2303: add support for tx xon/xoff flow control")
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > 
> > > @@ -176,7 +178,7 @@ static const struct pl2303_type_data pl2303_type_data[TYPE_COUNT] = {
> > >  	[TYPE_01] = {
> > >  		.max_baud_rate		= 1228800,
> > >  		.quirks			= PL2303_QUIRK_LEGACY,
> > > -		.no_autoxonxoff		= 1,
> > > +		.no_autoxonxoff		= true,
> > 
> > This chunk was supposed to go in the first patch. I'll fix that up
> > before applying (or resending).
> 
> With that fixup:
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for reviewing, now applied.

Johan

             reply	other threads:[~2019-04-03  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  7:48 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-04-02 12:04 [2/2] USB: serial: pl2303: fix tranceiver suspend mode Greg Kroah-Hartman
2019-04-02  8:22 Johan Hovold
2019-04-02  8:19 Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403074837.GE6734@localhost \
    --to=johan@kernel.org \
    --cc=charlesyeh522@gmail.com \
    --cc=florz@florz.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).