From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,4/6] usb: roles: add API to get usb_role_switch by node From: Heikki Krogerus Message-Id: <20190410102239.GG20058@kuha.fi.intel.com> Date: Wed, 10 Apr 2019 13:22:39 +0300 To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: T24gV2VkLCBBcHIgMDMsIDIwMTkgYXQgMTA6MDk6MTJBTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+IEFkZCBmd25vZGVfdXNiX3JvbGVfc3dpdGNoX2dldCgpIHRvIG1ha2UgZWFzaWVyIHRv IGdldAo+IHVzYl9yb2xlX3N3aXRjaCBieSBmd25vZGUgd2hpY2ggcmVnaXN0ZXIgaXQuCj4gSXQn cyB1c2VmdWwgd2hlbiB0aGVyZSBpcyBub3QgZGV2aWNlX2Nvbm5lY3Rpb24gcmVnaXN0ZXJlZAo+ IGJldHdlZW4gdHdvIGRyaXZlcnMgYW5kIG9ubHkga25vd3MgdGhlIGZ3bm9kZSB3aGljaCByZWdp c3Rlcgo+IHVzYl9yb2xlX3N3aXRjaC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4g PGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4gLS0tCj4gdjMgY2hhbmdlczoKPiAgIDEuIHVz ZSBmd25vZGVzIGluc3RlYWQgb2Ygbm9kZSBzdWdnZXN0ZWQgYnkgQW5keQo+ICAgMi4gcmVidWls ZCB0aGUgQVBJIHN1Z2dlc3RlZCBieSBIZWlra2kKPiAKPiB2MiBubyBjaGFuZ2VzCj4gLS0tCj4g IGRyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gIGluY2x1ZGUvbGludXgvdXNiL3JvbGUuaCAgfCAgMiArKwo+ICAyIGZpbGVzIGNo YW5nZWQsIDMzIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivcm9s ZXMvY2xhc3MuYyBiL2RyaXZlcnMvdXNiL3JvbGVzL2NsYXNzLmMKPiBpbmRleCBmNDVkOGRmNWNm YjguLjVlY2I1N2Y4OTYwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5j Cj4gKysrIGIvZHJpdmVycy91c2Ivcm9sZXMvY2xhc3MuYwo+IEBAIC0xMiw2ICsxMiw3IEBACj4g ICNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ ICAjaW5jbHVkZSA8bGludXgvbXV0ZXguaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mLmg+Cj4gICNp bmNsdWRlIDxsaW51eC9zbGFiLmg+Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGNsYXNzICpyb2xlX2Ns YXNzOwo+IEBAIC0xMzUsNiArMTM2LDM2IEBAIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnVzYl9y b2xlX3N3aXRjaF9nZXQoc3RydWN0IGRldmljZSAqZGV2KQo+ICB9Cj4gIEVYUE9SVF9TWU1CT0xf R1BMKHVzYl9yb2xlX3N3aXRjaF9nZXQpOwo+ICAKPiArc3RhdGljIGludCBfX3N3aXRjaF9tYXRj aF9md25vZGUoc3RydWN0IGRldmljZSAqZGV2LCBjb25zdCB2b2lkICpmd25vZGUpCj4gK3sKPiAr CXJldHVybiBkZXZfZndub2RlKGRldi0+cGFyZW50KSA9PSAoY29uc3Qgc3RydWN0IGZ3bm9kZV9o YW5kbGUgKilmd25vZGU7Cj4gK30KCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBhY3R1YWxseSBuZWVk ZWQuIFdoeSBub3QganVzdCBhc3NpZ24gdGhlCnBhcmVudCdzIGZ3bm9kZSBmb3IgdGhlIG11eCBh cyB3ZWxsPwoKSSdsbCBhZGQgYW4gZXhhbXBsZSB0byB0aGUgcGF0Y2ggNi82IGluIHRoaXMgc2Vy aWVzLgoKPiArLyoqCj4gKyAqIGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0IC0gRmluZCBVU0Ig cm9sZSBzd2l0Y2ggYnkgaXQncyBwYXJlbnQgZndub2RlCj4gKyAqIEBmd25vZGU6IFRoZSBmd25v ZGUgdGhhdCByZWdpc3RlciBVU0Igcm9sZSBzd2l0Y2gKPiArICoKPiArICogRmluZHMgYW5kIHJl dHVybnMgcm9sZSBzd2l0Y2ggcmVnaXN0ZXJlZCBieSBAZndub2RlLiBUaGUgcmVmZXJlbmNlIGNv dW50Cj4gKyAqIGZvciB0aGUgZm91bmQgc3dpdGNoIGlzIGluY3JlbWVudGVkLgo+ICsgKi8KPiAr c3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqCj4gK2Z3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KHN0 cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUpCj4gK3sKPiArCXN0cnVjdCB1c2Jfcm9sZV9zd2l0 Y2ggKnN3Owo+ICsJc3RydWN0IGRldmljZSAqZGV2Owo+ICsKPiArCWRldiA9IGNsYXNzX2ZpbmRf ZGV2aWNlKHJvbGVfY2xhc3MsIE5VTEwsIGZ3bm9kZSwKPiArCQkJCV9fc3dpdGNoX21hdGNoX2Z3 bm9kZSk7CgpTbyBoZXJlIHlvdSBjYW4gdGhlbiByZXVzZSBzd2l0Y2hfZndub2RlX21hdGNoKCk6 CgoJZGV2ID0gY2xhc3NfZmluZF9kZXZpY2Uocm9sZV9jbGFzcywgTlVMTCwgZndub2RlLCBzd2l0 Y2hfZndub2RlX21hdGNoKTsKCj4gKwlpZiAoIWRldikKPiArCQlyZXR1cm4gRVJSX1BUUigtRVBS T0JFX0RFRkVSKTsKPiArCj4gKwlzdyA9IHRvX3JvbGVfc3dpdGNoKGRldik7Cj4gKwlXQVJOX09O KCF0cnlfbW9kdWxlX2dldChzdy0+ZGV2LnBhcmVudC0+ZHJpdmVyLT5vd25lcikpOwo+ICsKPiAr CXJldHVybiBzdzsKPiArfQo+ICtFWFBPUlRfU1lNQk9MX0dQTChmd25vZGVfdXNiX3JvbGVfc3dp dGNoX2dldCk7Cj4gKwo+ICAvKioKPiAgICogdXNiX3JvbGVfc3dpdGNoX3B1dCAtIFJlbGVhc2Ug aGFuZGxlIHRvIGEgc3dpdGNoCj4gICAqIEBzdzogVVNCIFJvbGUgU3dpdGNoCj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaCBiL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaAo+ IGluZGV4IGMwNWZmYTZhYmRhOS4uZDIxY2Q1NWQ5ZTQ1IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUv bGludXgvdXNiL3JvbGUuaAo+ICsrKyBiL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaAo+IEBAIC00 Niw2ICs0Niw4IEBAIGludCB1c2Jfcm9sZV9zd2l0Y2hfc2V0X3JvbGUoc3RydWN0IHVzYl9yb2xl X3N3aXRjaCAqc3csIGVudW0gdXNiX3JvbGUgcm9sZSk7Cj4gIGVudW0gdXNiX3JvbGUgdXNiX3Jv bGVfc3dpdGNoX2dldF9yb2xlKHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnN3KTsKPiAgc3RydWN0 IHVzYl9yb2xlX3N3aXRjaCAqdXNiX3JvbGVfc3dpdGNoX2dldChzdHJ1Y3QgZGV2aWNlICpkZXYp Owo+ICB2b2lkIHVzYl9yb2xlX3N3aXRjaF9wdXQoc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqc3cp Owo+ICtzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKPiArZndub2RlX3VzYl9yb2xlX3N3aXRjaF9n ZXQoc3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9kZSk7Cj4gIAo+ICBzdHJ1Y3QgdXNiX3JvbGVf c3dpdGNoICoKPiAgdXNiX3JvbGVfc3dpdGNoX3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2UgKnBhcmVu dCwKPiAtLSAKPiAyLjIwLjEKCnRoYW5rcywK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2108C10F11 for ; Wed, 10 Apr 2019 10:22:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA54A206B7 for ; Wed, 10 Apr 2019 10:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbfDJKWq (ORCPT ); Wed, 10 Apr 2019 06:22:46 -0400 Received: from mga05.intel.com ([192.55.52.43]:35502 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729002AbfDJKWq (ORCPT ); Wed, 10 Apr 2019 06:22:46 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 03:22:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="163012491" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 10 Apr 2019 03:22:40 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 10 Apr 2019 13:22:39 +0300 Date: Wed, 10 Apr 2019 13:22:39 +0300 From: Heikki Krogerus To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node Message-ID: <20190410102239.GG20058@kuha.fi.intel.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190410102239.GG1AALqjxUORKwArvXnwlXKl9HZ7w0KhkH16Js8WTOg@z> On Wed, Apr 03, 2019 at 10:09:12AM +0800, Chunfeng Yun wrote: > Add fwnode_usb_role_switch_get() to make easier to get > usb_role_switch by fwnode which register it. > It's useful when there is not device_connection registered > between two drivers and only knows the fwnode which register > usb_role_switch. > > Signed-off-by: Chunfeng Yun > --- > v3 changes: > 1. use fwnodes instead of node suggested by Andy > 2. rebuild the API suggested by Heikki > > v2 no changes > --- > drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ > include/linux/usb/role.h | 2 ++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c > index f45d8df5cfb8..5ecb57f8960b 100644 > --- a/drivers/usb/roles/class.c > +++ b/drivers/usb/roles/class.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > > static struct class *role_class; > @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) > } > EXPORT_SYMBOL_GPL(usb_role_switch_get); > > +static int __switch_match_fwnode(struct device *dev, const void *fwnode) > +{ > + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; > +} I don't think this is actually needed. Why not just assign the parent's fwnode for the mux as well? I'll add an example to the patch 6/6 in this series. > +/** > + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode > + * @fwnode: The fwnode that register USB role switch > + * > + * Finds and returns role switch registered by @fwnode. The reference count > + * for the found switch is incremented. > + */ > +struct usb_role_switch * > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) > +{ > + struct usb_role_switch *sw; > + struct device *dev; > + > + dev = class_find_device(role_class, NULL, fwnode, > + __switch_match_fwnode); So here you can then reuse switch_fwnode_match(): dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); > + if (!dev) > + return ERR_PTR(-EPROBE_DEFER); > + > + sw = to_role_switch(dev); > + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); > + > + return sw; > +} > +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); > + > /** > * usb_role_switch_put - Release handle to a switch > * @sw: USB Role Switch > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > index c05ffa6abda9..d21cd55d9e45 100644 > --- a/include/linux/usb/role.h > +++ b/include/linux/usb/role.h > @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > struct usb_role_switch *usb_role_switch_get(struct device *dev); > void usb_role_switch_put(struct usb_role_switch *sw); > +struct usb_role_switch * > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); > > struct usb_role_switch * > usb_role_switch_register(struct device *parent, > -- > 2.20.1 thanks, -- heikki