From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,6/6] usb: mtu3: register a USB Role Switch for dual role mode From: Heikki Krogerus Message-Id: <20190410102415.GH20058@kuha.fi.intel.com> Date: Wed, 10 Apr 2019 13:24:15 +0300 To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: T24gV2VkLCBBcHIgMDMsIDIwMTkgYXQgMTA6MDk6MTRBTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+ICtzdGF0aWMgaW50IHNzdXNiX3JvbGVfc3dfcmVnaXN0ZXIoc3RydWN0IG90Z19zd2l0 Y2hfbXRrICpvdGdfc3gpCj4gK3sKPiArCXN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2hfZGVzYyByb2xl X3N4X2Rlc2MgPSB7IDAgfTsKPiArCXN0cnVjdCBzc3VzYl9tdGsgKnNzdXNiID0KPiArCQljb250 YWluZXJfb2Yob3RnX3N4LCBzdHJ1Y3Qgc3N1c2JfbXRrLCBvdGdfc3dpdGNoKTsKPiArCj4gKwlp ZiAoIW90Z19zeC0+cm9sZV9zd191c2VkKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJvbGVfc3hf ZGVzYy5zZXQgPSBzc3VzYl9yb2xlX3N3X3NldDsKPiArCXJvbGVfc3hfZGVzYy5nZXQgPSBzc3Vz Yl9yb2xlX3N3X2dldDsKCiAgICAgICAgcm9sZV9zd19kZXNjLmZ3bm9kZSA9IGRldl9md25vZGUo c3N1c2ItPmRldik7Cgo+ICsJb3RnX3N4LT5yb2xlX3N3ID0gdXNiX3JvbGVfc3dpdGNoX3JlZ2lz dGVyKHNzdXNiLT5kZXYsICZyb2xlX3N4X2Rlc2MpOwo+ICsKPiArCXJldHVybiBQVFJfRVJSX09S X1pFUk8ob3RnX3N4LT5yb2xlX3N3KTsKPiArfQoKdGhhbmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C8BC10F14 for ; Wed, 10 Apr 2019 10:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBDAA2075B for ; Wed, 10 Apr 2019 10:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730453AbfDJKYX (ORCPT ); Wed, 10 Apr 2019 06:24:23 -0400 Received: from mga12.intel.com ([192.55.52.136]:43939 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727497AbfDJKYX (ORCPT ); Wed, 10 Apr 2019 06:24:23 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 03:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="163012781" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 10 Apr 2019 03:24:16 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 10 Apr 2019 13:24:15 +0300 Date: Wed, 10 Apr 2019 13:24:15 +0300 From: Heikki Krogerus To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [v3 PATCH 6/6] usb: mtu3: register a USB Role Switch for dual role mode Message-ID: <20190410102415.GH20058@kuha.fi.intel.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-7-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1554257354-7440-7-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190410102415.EagWnqTis06lKjWNUAvWvyZRm2DN2pHevmIPi4BqwyY@z> On Wed, Apr 03, 2019 at 10:09:14AM +0800, Chunfeng Yun wrote: > +static int ssusb_role_sw_register(struct otg_switch_mtk *otg_sx) > +{ > + struct usb_role_switch_desc role_sx_desc = { 0 }; > + struct ssusb_mtk *ssusb = > + container_of(otg_sx, struct ssusb_mtk, otg_switch); > + > + if (!otg_sx->role_sw_used) > + return 0; > + > + role_sx_desc.set = ssusb_role_sw_set; > + role_sx_desc.get = ssusb_role_sw_get; role_sw_desc.fwnode = dev_fwnode(ssusb->dev); > + otg_sx->role_sw = usb_role_switch_register(ssusb->dev, &role_sx_desc); > + > + return PTR_ERR_OR_ZERO(otg_sx->role_sw); > +} thanks, -- heikki